Mattermost-server: Port the "channel modify" subcommand from Mattermost CLI to mmctl

[mattermod]

This ticket includes the creation of a "channel modify" subcommand in mmctl based on the Mattermost CLI command that can be found in cmd/mattermost/commands/channel.go.

This command can make use of the UpdateChannelPrivacy function of the model/client4.go file from the mattermost-server, and it should mimic the structure and the behavior of the Mattermost CLI, with the exception of the --username flag that the Mattermost CLI currently receives and will not necessary in mmctl.

As part of this ticket, the "channel make_private" subcomand should be removed from mmctl, as the creation of "channel modify" makes it obsolete.

---

If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Developer's Guide.

JIRA: https://mattermost.atlassian.net/browse/MM-20829

[3mard]

May I take this one ?

[jasonblais]

Hey @3mard, let us know if you have any questions so far, we'd be happy to help. Thanks so much for your interest on this :)

[3mard]

Hey @jasonblais thanks for your ping
I am trying to push #13102 through first, I understand that I might have jumped a bit too fast on this, I will be able to tickle this during the next week, but if that's already to late, I would understand if you chose to unassign me :)

[jasonblais]

Hey @3mard, that should be fine if you're planning to work on it next week :+1:

To confirm, did you mean you're working on https://github.com/mattermost/mattermost-server/issues/13103 first?

[3mard]

Sorry for the confusion @jasonblais I meant #13275

[jasonblais]

Ah, excellent, thanks @3mard!

[3mard]

Hi @jasonblais,
I couldn't tickle this during the holiday season, sorry for the inconvenience
there is a small work left for #13275 to be done, and I still mean to work on this, however If you feel like it's best to reassign this, go for it .

[jasonblais]

Hey @3mard! Thanks for the heads up and no worries :) We can catch up in a couple of weeks to see where things are at. Appreciate the follow-up!

[jasonblais]

Hi @3mard - with some work left on #13275, I'll open this up for grabs. If you're interested to take it on after #13275, that's great as well! :)

[larkox]

May I take this one?

[jasonblais]

Go for it @larkox :)