Mattermost-server: "Send message on Ctrl+Enter" should say "Cmd+Enter" on a Mac
On Mac, this setting should have the title "Send messages on ⌘+ENTER" and the help text should read "When enabled, ⌘ + ENTER will send the message and ENTER inserts a new line.
If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.
New contributors please see our Developer's Guide.
mattermod
All 6 comments
i will take this
just looked into this. not easy to do because this is taken from en.json and that can not be rendered conditionally on. Utils.isMac()
allenlai18
on 20 Nov 2019
@hmhealey any guidance you can provide here ^?
esethna
on 20 Nov 2019
In that case, you could have two separate strings in en.json and switch between them in the JS code. I believe that's what we do elsewhere for OS-specific translation strings.
hmhealey
on 20 Nov 2019
I will take this on. i figured out a way!
allenlai18
on 20 Nov 2019
is this ready to be closed?
allenlai18
on 11 Dec 2019
Whoops, good catch. I'm used to them being autoclosed by the PR, but I think you need some special comment to do that. Closing it now
hmhealey
on 11 Dec 2019
Related issues
esethna
·
3Comments
esethna
·
3Comments
esethna
·
3Comments
tumbl3w33d
·
3Comments
esethna
·
3Comments