Mattermost-server: Remove deprecated lifecycle methods from login screens

Created on 24 Sep 2019  路  5Comments  路  Source: mattermost/mattermost-server

The following React lifecycle methods have been deprecated by React and will start to be removed starting in React 17:

  • componentWillMount
  • componentWillReceiveProps
  • componentWillUpdate

The React team has published a guide discussing the changes and how to migrate to the new lifecycle methods here: https://reactjs.org/blog/2018/03/27/update-on-async-rendering.html

As part of a campaign to remove these methods from https://github.com/mattermost/mattermost-mobile, these methods should be replaced in the following files:

  • app/screens/select_team/select_team.js
  • app/screens/login/login.js
  • app/components/client_upgrade_listener/client_upgrade_listener.js

If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Developer's Guide.

JIRA: https://mattermost.atlassian.net/browse/MM-18769

AreTechnical Debt Medium Hacktoberfest Help Wanted TecReact Native

All 5 comments

I can take a shot at this if its ok with you

Great, thanks @icancode007!

Permission to mattermost/mattermost-mobile.git denied to icancode007.
getting this when I attempt to push my branch up any ideas

Hey @icancode007, you need to fork the mattermost-mobile repo and then push the changes to your fork.

Hi can I work on this

Was this page helpful?
0 / 5 - 0 ratings