Mattermost-server: Complete migration of channel_actions to redux actions

Created on 28 Jun 2019  路  10Comments  路  Source: mattermost/mattermost-server

If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Developer's Guide.


Notes: Jira ticket

This is part of the technical debt epic
Details at https://mattermost.atlassian.net/browse/MM-12173

Migrate channel_actions to redux actions and update all the necessary components

AreTechnical Debt Easy Help Wanted PR Exists TecRedux

All 10 comments

馃憢 I'll tackle this one.

@esethna can you confirm that the idea is to just remove the oauth actions from integraion_actions.jsx? There is no actual oauth_acions file.

Similar work was done previously on #10153.

@hanzei @esethna I had a question about doing the work for this one but never got a reply. Unfortunately I don't have time to complete the ticket now so perhaps we could add the Up For Grabs tag back on?

Sorry!

Hey @amorriscode,

I'm sorry for missing your question. Still, thanks for the time you spend with this issue.

@hanzei I would like to try this out. However, @amorriscode had a question up there that I think when answered would give me some more guidance on how to complete this.

Awesome, thanks @AGMETEOR :tada:

@saturninoabril Can you help with the question? https://github.com/mattermost/mattermost-server/issues/11442#issuecomment-506570031

I think this ticket is no longer valid and should just be updated to which action to migrate. The integration part is almost done, just need to get rid off using global store. I'd recommend to make this as "Complete migration of channel_actions to redux actions", particularly

  • autocompleteChannels
  • autocompleteChannelsForSearch

Will update the ticket accordingly.

Thank you @saturninoabril , I will attempt this now.

@saturninoabril I have a draft PR up for this... working to complete migrations for all the other actions in channel_actions.js

Hello @saturninoabril PR now exists

Also, the build-docker CI stage seems to be blocked. I don't know why that's happening.

Was this page helpful?
0 / 5 - 0 ratings