Mattermost-server: Complete migration of diagnostic_actions to redux actions

[esethna]

If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Developer's Guide.

---

Notes: Jira ticket

This is part of the technical debt epic
Details at https://mattermost.atlassian.net/browse/MM-12173

Migrate diagnostic_actions to redux actions and update all the necessary components

[goku321]

This one as well?

[jespino]

Great!

[goku321]

Hi @jespino I will not be able to work on this at the moment. Can you please put Up For Grabs label again? Thank you for your patience.

[hanzei]

Hey @goku321,

Thanks for the heads up. :+1:

[AGMETEOR]

@hanzei I would like to take this up...

[hanzei]

Sure, thanks @AGMETEOR

[AGMETEOR]

Just a question for @jespino and @hanzei , do I have to first make some changes in the mattermost-redux codebase? For example, I might need to add a actions/diagnostics.ts in mattermost-redux then as an example for migrating trackEvent in the webapp's diagnostics_actions.js file, I add something like this to mattermost-redux

export function trackEvent(category: string, event:string, props: object): ActionFunc {
    return bindClientFunc({
        clientFunc: Client4.trackEvent,
        onRequest: DiagnosticTypes.TRACK_EVENT_REQUEST,
        onSuccess: [DiagnosticTypes.TRACK_EVENT_SUCCESS],
        onFailure: DiagnosticTypes.TRACK_EVENT_FAILURE,
        params: [
           category,
           event,
           props,
        ],
    });
}

[AGMETEOR]

Hello @hanzei , I just wanted to draw your attention to this :)

[hanzei]

@sudheerDev Can you help with this question?

[jasonblais]

Hi @sudheerDev / @jespino, wondering if you can help with the question above, or direct to someone who can?

[jespino]

@AGMETEOR Sorry for the super super super late reply about this. The idea is to migrate this only for the webapp part, so I don't see the need of the changes in the mattermost-redux repo.

My proposal would be migrate what are utility functions to utils/diagnostics.tsx and migrate the actions to something like your trackEvent action function proposal.

[AGMETEOR]

@jespino thanks a lot. I have forgotten about this issue. Will try working on it again.

[jespino]

@AGMETEOR Thanks! and sorry again about the delay.