Mattermost-server: Add status icons on "add member to channel" list

[esethna]

If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Developer's Guide.

---

Notes: Jira ticket

Original report here: https://github.com/mattermost/mattermost-server/issues/8258

Summary

The Add Members lists, from Channel name drop-down > 'Add Members' do not display the status icon on users' profile pictures.
Status icons are currently displayed on all other Members lists.

Steps to reproduce

1. Log in to Mattermost - Version: 4.7.0 (4.7.0-rc2)
2. Select any public or private channel
3. Select the Channel name dropdown, above the chat window
4. Select 'Add Members'
5. View 'Add New Members to [channel_name]' list

Expected behavior

All Members lists display a status icon on a user's profile picture from the Channel name drop-down > Manage (or View or Add) Members

Observed behavior
Selecting Channel name drop-down > 'Add Members' displays a list of users, but does not display a status icon on a user's profile picture.

[Sheshagiri]

does it involve UI changes as well(mattermost-webapp)?

[jespino]

Oops, I tagged it wrongly, yes it's mainly mattermost-webapp changes

[Siddharth-Ashri]

I'll take this one. Ive been learning react and would love to contribute to Open-Source project like this.

[hanzei]

Hey @Siddharth-Ashri,

Thanks for taking a shot on this issue. Feel free to join the Mattermost Community Server and ask any questions you have there.

[amoury]

I would love to contribute to this one...is it done already?

[Siddharth-Ashri]

Do I have to setup both the web app and the server?

[hanzei]

@Siddharth-Ashri Yes, you have. Let me know, if you need further help.

[hanzei]

@amoury Thanks for your interest in this issue. Currently @Siddharth-Ashri is working on this.

We mark available ticket will the "Up For Grabs" label. With the following query you can find all React ticket that are available: https://github.com/mattermost/mattermost-server/issues?q=is%3Aopen+label%3ATech%2FReactJS+label%3A%22Up+For+Grabs%22

[hanzei]

Hey @Siddharth-Ashri,

Do you successfully set up your dev environment? Looking forward to your PR.

[Siddharth-Ashri]

Hey @hanzei I've been having some trouble trying to set up the environment I've got the server up and running but for some reason front-end does not show up. I will try again later tonight. and try to upload a PR ASAP

[Siddharth-Ashri]

Hey @Siddharth-Ashri,

Do you successfully set up your dev environment? Looking forward to your PR.

Hi @hanzei I am having issues setting up my dev environment, where can I get some help? I have tried asking in the contributor community but I have not yet received a response.

[hanzei]

Hey @Siddharth-Ashri, did you got your dev environment running? If not, feel free to ping me on the community server.

[hanzei]

Making this one available for the public again due to inactivity. @Siddharth-Ashri let me know, if you still want to work on this.

[amoury]

@hanzei I am still interested to give this a shot

[hanzei]

Awesome, thanks @amoury :tada:

[amoury]

@hanzei Thanks for assigning it to me. I am trying to setup the server part and ran into this error after running the command make run-server

ERROR: for postgres  Cannot start service postgres: driver failed programming external connectivity on endpoint mattermost-postgres (f4a30d706fc2216ca64a378ecf5557eb1bb06c4eebe125c1f298f948101a15bd): Error starting userland proxy: Bind for 0.0.0.0:5432 failed: port is already allocated
ERROR: Encountered errors while bringing up the project.
make: *** [start-docker] Error 1

I ran docker ps to check if there was any container running on port 5432, but there is none. Can you please give me some direction on how I can get around this?

By the way, here is the screenshot from docker ps command

Thanks

[hanzei]

@amoury Would you please check what sudo lsof -i -P -n | grep LISTEN | grep 5432 reports?

[amoury]

@hanzei Running that command gives me this. To me it looks like postgres is running and listening to the connection. But still running the curl ping command does not return me the JSON.

[hanzei]

@amoury Would you mind sending me a DM on the Mattermost Community Server? This conversation is driving away from the original topic.

[amoury]

@hanzei Here is my PR for this issue - https://github.com/mattermost/mattermost-webapp/pull/3825
Thanks

[hanzei]

This doesn't seem to be an issue any longer.

[esethna]

@hanzei I think this issue is still valid?

Updated the description to remove the text about team members list given that one doesn't exist anymore with the new invite flow

[hanzei]

@esethna You are correct, thanks for double checking :+1:

[courtneypattison]

I'll take this one :)

[esethna]

@courtneypattison note that there's another PR in progress in this area so please take a look to avoid conflicts :)

https://github.com/mattermost/mattermost-webapp/pull/7172

[courtneypattison]

@esethna Thank you for the heads up! Some of the files overlap, but it looks like they should be simple merges.