Mattermost-server: Migrate "Channel.ResetAllChannelSchemes" to Sync by default

Created on 18 Jun 2019  路  1Comment  路  Source: mattermost/mattermost-server

If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Developer's Guide.


Notes: Jira ticket

Mattermost is migrating its Store layer to be sync by default, and only use Async when needed and we're looking for contributors to help with that effort. This Help Wanted issue is to migrate the ResetAllChannelSchemes in the Channel store.

The expected way to implement it is, go to the Channel store implementation in the store/sqlstore/ directory, modify the method ResetAllChannelSchemes to return directly an object from the model module, and a *model.AppError (removing the store.Do wrapper). After that, you must modify the interface defined in store/store.go to match with the changes. Then, you should execute make store-mocks to rebuild the mocks with the new interface. And finally, modify the rest of the code (tests included) to use the new interface of the function properly.

Example: mattermost/mattermost-server#10613

AreTechnical Debt Easy Help Wanted PR Exists TecGo

Most helpful comment

Getting done this

>All comments

Getting done this

Was this page helpful?
0 / 5 - 0 ratings