Mattermost-server: [MM-15302] Migrate "Preference.Delete" to Sync by default

[esethna]

If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Developer's Guide.

---

Notes: Jira ticket

Mattermost is migrating its Store layer to be sync by default, and only use Async when needed and we're looking for contributors to help with that effort. This Help Wanted issue is to migrate the Delete in the Preference store.

The expected way to implement it is, go to the Preference store implementation in the store/sqlstore/ directory, modify the method Delete to return directly an object from the model module, and a *model.AppError (removing the store.Do wrapper). After that, you must modify the interface defined in store/store.go to match with the changes. Then, you should execute make store-mocks to rebuild the mocks with the new interface. And finally, modify the rest of the code (tests included) to use the new interface of the function properly.

Example: mattermost/mattermost-server#10613

[souvik3333]

Hi, Can I work on this?

[jasonblais]

Certainly, thank you @souvik3333! If you have any questions, don't hesitate to let us know.

[hanzei]

Hey @souvik3333,

How is your work on this ticket going?

[Inconnu08]

Hey @souvik3333 if you're not able to make time, may I work on this?

[souvik3333]

Sure.

On Wed 5 Jun, 2019, 12:01 AM Taufiq Rahman, [e-mail]
wrote:

Hey @souvik3333 https://github.com/souvik3333 if you're not able to
make time, may I work on this?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mattermost/mattermost-server/issues/10715?email_source=notifications&email_token=AF5RL7LUTA5LTVY5YU24QTLPY2YJ5A5CNFSM4HIQPACKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODW5O3YQ#issuecomment-498789858,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AF5RL7MINO6WT4AIBW36LNTPY2YJ5ANCNFSM4HIQPACA
.