Mattermost-server: Channel switcher auto-complete doesn't function properly when auto-completing the name of a person who is the first person named in a group DM channel - Mattermost Server 5.10

Created on 25 Apr 2019  路  7Comments  路  Source: mattermost/mattermost-server

Summary

Auto-complete doesn't function properly when auto-completing the name of a person who is the first person named in a group DM channel

Steps to reproduce

  • Create multiple group DM channels with PERSON A listed first
  • Switch from viewing user names to full names under display settings
  • Create more group DM channels with PERSON A listed
  • CTRL+K to switch channels
  • Start to type the name of the first person
  • Use the arrow key to scroll down

Appears on community.mattermost.com but not on oss.mattermost.com

Expected behavior

  • Down arrow key allows me to go down the list

Observed behavior (that appears unintentional)

Duplicate Group DMs shown, and can't arrow down past them

image

image

image
image

Possible fixes

If you can, link to the line of code that might be responsible for the problem

NOTE: Please let me know if I'm eligible for a Bug Hunter Coin on this report? I can be reached at 855 El Camino Real, 13A-168, Palo Alto, CA, 94301. I'd like test out the experience of getting one. Btw, one benefit of the coin program is that it only applies to filing a ticket in GitHub and not just adding the info in a channel.

Bug ReporOpen

Most helpful comment

I started looking at this last night and I think I have discovered the issue causing the duplicate GMs that @it33 is seeing. I'll be submitting a fix for that sometime today. The issue that @hanzei is seeing is related but different and is a known issue that's going to require a significant reworking of our autocomplete suggestion to fix so at this time it's not worth the effort, see https://mattermost.atlassian.net/browse/MM-11193

All 7 comments

Hi @it33,

Is this reproducing for you consistently and is there any other additional information you might be able to share (e.g. OS and version)?

I wasn't able to reproduce this and our QAs weren't able to reproduce it so far either.

I've run into the same problem.

Environment:

Steps to repo:

  • Open a DM channel to @remindbot and let it stay on the LTS
  • Open the channel switcher in any channel.
  • Type rem

Observed behaviour:
Screenshot from 2019-04-28 07-55-01
I also can't use the keyboard to select the channel.

Expected behaviour:

  • Remindbot only shows up once
  • I can select an entry with the keyboard.

Repos 100% with this steps. I'm not sure if this is related to bot accounts or not. I've only been able to repo this bug with this specific user account(@remindbot).

Windows 10 on latest Chrome

@amyblais yes, I'm still having the issue. Not sure if this is related but as I try different searches for channel sometimes I get the wrong results in auto-complete, e.g. "ar" doesn't appear in any of these results:

image

This list can stay there for 10 seconds or more (i..e if it's a lazy-load issue it takes a while). When I leave the tab and navigate back then it looks like it works:

image

However the original problem of duplicate channels and then down arrow being able to move past the duplicate entries, is still here

image

Then when I try az I get the right results and group DMs incorrectly

image

I'm finding a pattern where group direct message channels are incorrectly showing up in the channel search.

image

I opened a bug ticket for this here: https://mattermost.atlassian.net/browse/MM-15363.

I'll look into the Bug Hunter Coin shortly,

I started looking at this last night and I think I have discovered the issue causing the duplicate GMs that @it33 is seeing. I'll be submitting a fix for that sometime today. The issue that @hanzei is seeing is related but different and is a known issue that's going to require a significant reworking of our autocomplete suggestion to fix so at this time it's not worth the effort, see https://mattermost.atlassian.net/browse/MM-11193

@it33 I've coordinated with Corey to send out a Bug Hunter Coin for you. Thank you for reporting this!

Closing this issue as this has been fixed for upcoming v5.12 release (to be released in June 16th).

Was this page helpful?
0 / 5 - 0 ratings