Mattermost-server: Add password type for Interactive Dialogs

[esethna]

If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Developer's Guide.

---

Notes: Jira ticket

Interactive Dialogs allow integrations to receive some form-styled input from users and have that input submitted back to the integration. An Interactive Dialog consists of a list of elements. These elements have a defined type such as text or select. Elements with the type text can also have a sub type, that defines how the field is shown and what keyboard is used.

This ticket is about adding a sub type password. When subtype is set to password the characters of the field should be obfuscated when written.

This ticket requires changes in both the web app and the mobile app.

For more information about Interactive Dialog, see https://docs.mattermost.com/developer/interactive-dialogs.html

If you have any questions or would like feedback, feel free to ask in the Developer Toolkit channel on our Mattermost community instance.

[goku321]

Can I take this one up?

[hanzei]

Sure. Thanks for working on this @goku321 :tada:

[goku321]

I need some help on this ticket. I did some code walk-through but couldn't figure out where to add password type. It would be helpful if i can get some starting point.

[hanzei]

Hey @goku321,

On the server side the type is defined by the subtype field in the payload. See https://docs.mattermost.com/developer/interactive-dialogs.html#text-elements

Or are you talking about the webapp part?

[goku321]

Hi @hanzei,
Thanks for your input. And, yes I was talking about the webapp part.

[hanzei]

@jwilander Can you help with the questions above? I'm not to familiar with the webapp code.

[jwilander]

@goku321 you'll likely want to make some changes in here to return a password input when the type is password
https://github.com/mattermost/mattermost-webapp/blob/master/components/interactive_dialog/dialog_element.jsx

[goku321]

@jwilander Thanks, this was helpful. A question: Would it be better to add a 'password' string to the array validTypes inside https://github.com/mattermost/mattermost-webapp/blob/master/components/widgets/settings/text_setting.jsx ?

[jwilander]

Yeah I think that'd be great @goku321 👍

[goku321]

Just a heads-up that I am working on the mobile app changes and currently, writing test cases for the changes made.

[hanzei]

This issue is resolved. Thank you very much @goku321 :tada: