Mattermost-server: Inline link with nested parentheses does not work

[esethna]

If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Developer's Guide.

---

Notes: Jira ticket

Original report: https://forum.mattermost.org/t/inline-link-with-nested-parentheses-does-not-work/6651

Summary
Not a regression.
Posting an inline link with nested parentheses in the URL does not work.

Steps to reproduce

1. Post this message: " how about: hmm? "

Expected behavior
Expect inline link with title hmm and URL https://somewhere?param=(currentUser())

Observed behavior
No inline link. The original markdown syntax appears directly. However, part of the URL (https://somewhere?param=) is then detected as an auto link and becomes clickable.

[scottleedavis]

I'd like to try this one. Not sure I understand the problem though.

[hanzei]

@amyblais Could you help defining the problem a bit more, as you created the ticket?

[amyblais]

It came from this community report: https://forum.mattermost.org/t/inline-link-with-nested-parentheses-does-not-work/6651. Let me know what needs to be clarified and I can ping our developers.

[hanzei]

Hey @scottleedavis,

Do you need more information to work on this? Is the one from the forum enough?

[scottleedavis]

I believe I understand well now, thank you @amyblais and @hanzei !

[scottleedavis]

The issue appears to be with the version of marked being used. When updating to the latest 0.6.2, the problem is solved, however seems to cause issues elsewhere with markdown rendering currently.

[scottleedavis]

Turns out, I should have been using mattermost/marked. Made the change there, and will pull in the appropriate repo hash when it is approved.