Mattermost-server: Plugin framework: add ability to upload other plugins to the plugin API

[esethna]

If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Developer's Guide.

---

Notes: Jira ticket

Plugins should be able to upload other plugins. To accomplish this add a UploadPlugin(file io.Reader) (*model.Manifest, *model.AppError) method to the plugin API.

Read about adding to the plugin API here https://developers.mattermost.com/contribute/server/plugins/.

You'll want to look at these files:

• https://github.com/mattermost/mattermost-server/blob/master/plugin/api.go
• https://github.com/mattermost/mattermost-server/blob/master/app/plugin_api.go

If you have any questions or would like feedback, feel free to ask in the Developer Toolkit channel on our Mattermost community instance.

---

This ticket is part of a larger campaign for adding plugin API methods. See here: https://github.com/mattermost/mattermost-server/issues/9458

[gupsho]

In the argument for the api, is it reader to the .tar.gz bundle for plugin?

[gupsho]

@tomasmik please go ahead and take it. I will take another one.

[hanzei]

In the argument for the api, is it reader to the .tar.gz bundle for plugin?

Yes, it is.

[hanzei]

On thing still to discuss is, if this methods should overwrite an existing installation of the plugin. I'm 1/5 on just overwriting, but there might be better solutions like only overwriting, when this updates the plugin version.

[hanzei]

@tomasmik Do you want to pick this up?

[tomasmik]

If it's ok that I will take some time to do this, then sure.

I do not have mattermost-server set up on my new laptop.

[hanzei]

@tomasmik Take the time you need. Let me know, if you have any questions or need help with the dev setup. Feel free to DM me on the Mattermost Community Server.

[fcorrea]

I'll take this one

[hanzei]

Sorry @fcorrea, this ticket is already taken. Please take a look a the other open Help Wanted ticket: https://github.com/mattermost/mattermost-server/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc+Help+Wanted+label%3A%22Up+For+Grabs%22

If you have further questions, feel free to DM me on the Mattermost Community Server.

[fcorrea]

I'm sorry @hanzei and @tomasmik ! I've mistakenly assumed it was "Up for Grabs" and that it was fine to take a look.
I'm stepping way from this one for now.

[hanzei]

Hey @tomasmik,

Just want to check how your work on this issue is going. Can I help with anything?

[tomasmik]

@hanzei hey, terribly sorry had some IRL troubles. I've set up the dev environment and am planning to work on this this weekend. I will let you know about my progress.

[hanzei]

Hey @tomasmik,

Checking in again: Did you successfully set up your dev environment?

[tomasmik]

I will have to drop the work. I'm facing some issues which are making it impossible to work on this. Im very sorry.

[hanzei]

No problem @tomasmik. Thanks for the heads up.

[hanzei]

@fcorrea do you still want to work on this?

[fcorrea]

@fcorrea do you still want to work on this?

Hey @hanzei. I'm currently tackling other issue but I'll keep an eye on this one. If it's still hanging when I'm done with the other, i'll pick it up. Otherwise, feel free to leave it open.

[hanzei]

I will take care of this.

[kevinetienne]

I'll pick this one, please.

[lieut-data]

Terrific! Thanks @kevinetienne :)

[lieut-data]

@kevinetienne, anything we can do to help with your efforts here?

[kevinetienne]

@lieut-data thanks, yeah still on it. Will ping on the 30th, July if no progress.

[hanzei]

Hey @kevinetienne,

do you have any questions?

[kevinetienne]

@hanzei no I have tweaked you pr and I was basically working on a test but didn't got too far, I'll push it today and see where we go from there.

[hanzei]

@kevinetienne Just want to touch bases: Can I help you in any way to get the tests going?

[hanzei]

Making this one available for the public again due to inactivity.

[niklabh]

Here is a pull request: https://github.com/mattermost/mattermost-server/pull/12232