Mattermost-server: Improve timezone selector component and list of timezones

[esethna]

If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Developer's Guide.

---

Notes: Jira ticket

Timezones must be enabled using the experimental config "ExperimentalTimezone"

---

This ticket is to update the current timezone selector UX in Account Settings > Display > Timezone

1. Update component to a drop down list:
   https://projects.invisionapp.com/share/W6QBT1ZJAFK#/screens/344809032
   https://projects.invisionapp.com/share/W6QBT1ZJAFK#/screens/344809033
2. Update list of available timezones to this: https://github.com/dmfilipenko/timezones.json/blob/master/timezones.json
3. When "Automatic" is selected, disable the dropdown: https://projects.invisionapp.com/share/W6QBT1ZJAFK#/screens/344811834/comments

[ry-wang]

I can try taking a look at this!

[hanzei]

Hey @R-Wang97,

Do are you doing with this ticket? Do you have questions?

[ry-wang]

Hey @hanzei, I've been busy recently, so I haven't had much of a chance to look at it. Could somebody else take over for me?

[jasonblais]

Certainly, no worries @R-Wang97! I'll add the Up for Grabs label back.

[Willyfrog]

I'd like to take a look into this one

[jasonblais]

Great, thank you @Willyfrog!

[jasonblais]

@lieut-data confirming point 2 in issue description still applies following latest changes to timezones.json?

[lieut-data]

Not the timezones.json, specifically, but to the hard-coded list now in the server: https://github.com/mattermost/mattermost-server/blob/master/services/timezones/default.go

[hanzei]

Hey @Willyfrog,

How are you doing with this ticket? Do you have any questions?

[hanzei]

Making this one available for the public again due to inactivity.

[lisakycho]

Hi, I can try to work on this!

[jasonblais]

Great, thank you @lisakycho!

[Willyfrog]

Hi, sorry @hanzei , life got in the way and was away for quite some time. I see @lisakycho already started, so I can share what I had if that helps him

[lisakycho]

@jasonblais, when you say update the list of available timezone, am i just updating the file services/timezones/default.go and calling the timezones the same way?

[jasonblais]

when you say update the list of available timezone, am i just updating the file services/timezones/default.go and calling the timezones the same way?

@asaadmahmood or @esethna would you know? I think you're more familiar with this help wanted issue

[asaadmahmood]

I think so. @jwilander, can you confirm?

[jwilander]

Yes that would be correct, as of https://github.com/mattermost/mattermost-server/pull/10311 the timezones.json was deprecated in favour of the hardcoded list. So if updates to the timezones are needed, it should be done to the hardcoded list.

[hanzei]

Hey @lisakycho,

Does the above answers solve your question?

[lisakycho]

@jwilander should I make my own struct to hard code this?

[jwilander]

There's already a slice of the timezones here https://github.com/mattermost/mattermost-server/blob/master/services/timezones/default.go

You would just need to update that if you need to change the timezones @lisakycho

[lisakycho]

@jwilander right but that contains an array of strings while the new timezones are an array of objects, not sure what type to declare for that array if i just replace the data.

[jwilander]

I'm not entirely sure, might take some investigation on your part. I think you can just keep it as an array of strings and update it to contain all the timezones in that list under the utc fields here https://github.com/dmfilipenko/timezones.json/blob/master/timezones.json#L45

[hanzei]

@lisakycho Do you have any outstanding questions?

[hanzei]

Making this one available for the public again due to inactivity.

[vintik]

@hanzei I'd like to work on this please.

[hanzei]

Alle yours, @vintik :+1:

[saturninoabril]

Hello @vintik, sorry but I'm currently working on this and finalizing the changes already. I forgot to make comment on this issue. Would you mind if you look for another help-wanted ticket?

[esethna]

@saturninoabril how is this going?

[saturninoabril]

Hello Eric, sorry for the delay. I'm releasing this from my item and will let the Webapp team to decide on how to work on it.

[hmhealey]

@saturninoabril Do you happen to have a WIP branch around for this?

[esethna]

@saturninoabril do you have a branch with this that we can take over or link to?

[esethna]

@vintik looks like Saturn isn't working on this anymore, still interested in taking this ticket?

[saturninoabril]

@esethna @hmhealey Sorry for late response. I searched with my branches and I can't find the one on the webapp. That might have wiped out when I replaced my laptop. Here are the server and redux branches but I don't think it will be helpful.

[IndushaS]

Hello @esethna, I'd like to try and work on this.

[jasonblais]

Thanks @IndushaS! :tada:

[esethna]

Yay, thanks @IndushaS. How's this going, need any help or guidance?