Mattermost-server: Add ability to remove custom branding image

[esethna]

If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Developer's Guide.

---

Notes: Jira ticket

Add the ability to remove a custom branding image similar to the flow implemented in Team Settings > Team Icon.

In System Console > Custom Branding > Custom Brand Image:

1. Update button text: "Choose New Image" > "Select Image"
2. Remove the upload button so the image uploads automatically after being selected from the file picker. So the button presses would be:
3. "Select Image" > File picker opens, user selects image, then it uploads automatically and generates the image preview (like how it does now).

1. Add an "x" button to the brand image preview once an image is selected. Tool tip: "Remove brand image"
2. When "x" is clicked, remove the brand image preview, but don't save until the user clicks "Save" on the system console page.

Invision screens: https://projects.invisionapp.com/share/T6O2PN04EFC#/screens/320132211

[jlevesy]

Hi folks, I'm interested in working on this !
I'll reach for more informations soon !

[amyblais]

Thank you @jlevesy! Feel free to ask any questions.

[jlevesy]

Just to keep you posted, I started to work on this on that branch.

I'll open a pull as soon as I get something interesting :)

[jlevesy]

Okay so status update :) :

• Server side implementation is done here #9552 (with documentation update here https://github.com/mattermost/mattermost-api-reference/pull/401)
• Redux and javascript client binding is here https://github.com/mattermost/mattermost-redux/pull/664
• I have a WIP branch here which does implement-ish the new UX.

Things that I still need to do:

• Trigger the deleteBrandImage call only when save is clicked (item 4). However I'm not sure how to do this because the save button only triggers a config update and I was not able to find a way to hook a custom action... I would love to get some insights about that :) !
• Style the deleteBrandImage button... and that is probably going to be the most painful for me ^^.

[amyblais]

@esethna Can you help with the questions on deleteBrandImag or ping a dev ^

[esethna]

Thanks @jlevesy!

@jespino any guidance you can provide on the first to do item above?

Regarding styling the button, we can have our team help with that after the PR is submitted if you'd prefer?

[jlevesy]

Regarding styling the button, we can have our team help with that after the PR is submitted if you'd prefer?

Thanks. I'll give it a try first :)

[grundleborg]

I've merged the server changes into master (for 5.6).

[hanzei]

@jlevesy How is your implementation going? Do you have any questions?

[hanzei]

Making this available to the public because there wasn't an update from @jlevesy for some time.

[steveperjesi]

I'll take this one.

[hanzei]

Thanks for looking into this @steveperjesi. Let us know, if you have any questions.

[hanzei]

Hey @steveperjesi,

I just want to check how your work on this going. Do you have any questions?

[steveperjesi]

Hi @hanzei I have all but the testing ready and it's been sitting in my dev. If my planets align tomorrow or Saturday, I'll put a PR so we can all take a look.

[hanzei]

Hey @stephenkiers,

Thanks for the update. Looking forward to your PR! :rocket:

[hanzei]

Hey @steveperjesi,

Just checking if you are still working on this and if you have questions.

[hanzei]

Making this one available for the public again due to inactivity.

[hahmadia]

Hey, could I have a go at this ticket?
Thanks :)

[hanzei]

Hey @hahmadia,

Thanks for working on this :+1: Let me know, if you have questions.

[steveperjesi]

Sure go ahead! I only worked on it for a minute before life happened.
Thanks for picking up my slack 👍

On Fri, Jul 19, 2019 at 4:54 PM Hossein Ahmadian-Yazdi <
[email protected]> wrote:

Hey, could I have a go at this ticket?
Thanks :)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mattermost/mattermost-server/issues/9507?email_source=notifications&email_token=AA42ILJZKSSQ62XUMYXIXU3QAISV5A5CNFSM4FYALDX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2MXPJA#issuecomment-513374116,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA42ILP5GNZJRWH3RARLWDDQAISV5ANCNFSM4FYALDXQ
.

[hahmadia]

Completed!
Awaiting code review and style review (I wasn't sure how to style the X button properly so any help and advice would be greatly appreciated since I didn't quite understand how to style a className.)

Thanks 😄

[saturninoabril]

PR has been merged. Thank you @hahmadia for your contribution!