Mattermost-server: [MM-9563] Add a red dot to browser favicon when there are unread mentions

[esethna]

If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Developer's Guide.

---

Notes: Jira ticket

When the user has unread mentions, the browser favicon should get a red dot, as in the following screenshot:

Favicon asset:

This feature should be supported on Chrome and Firefox, but not on Edge or Safari due to caching issues which made the favicon not appear reliably.

[mathieutougas]

I have a good experience with your codebase. I'd like to work on this.

[jasonblais]

Thank you @MathieuTougas! Please let us know if you have any questions

[hanzei]

Hey @MathieuTougas

Do you have any questions? Looking forward to this feature!

[hanzei]

Making this available to the public because there wasn't an update from @MathieuTougas for some time.

[onecuriousmiind]

I've managed to set up MM server and webapp. Everything looks good. I'd like to start with this.

[jasonblais]

Thank you @b-lawrence! Let us know if you have any questions while working on it.

[onecuriousmiind]

https://mattermost.atlassian.net/browse/MM-13643 indicates that updating the favicon when notifications are present was disabled for a reason. What's the verdict here?

[jasonblais]

Hey @b-lawrence, good question. Let me verify with our UX team but my understanding is that the design proposed here is still the one we want to use.

[jasonblais]

@b-lawrence I've posted the question to our UX team here : https://community.mattermost.com/core/pl/mayikusee78xubmk69bgn4bfpe

[jasonblais]

@b-lawrence Have confirmed that the design proposed here is still accurate. If you're interested helping with the implementation, that would be very much appreciated!

[onecuriousmiind]

Thanks, @jasonblais. I'll create the PR.

[onecuriousmiind]

PR created @jasonblais.

[jkl5616]

I'd like to take this!

[jasonblais]

Great, thank you @jkl5616! Let us know if you have any questions

[jkl5616]

@jasonblais It would be better if there are favicon assets of 32x32 and 96x96.

[jasonblais]

It would be better if there are favicon assets of 32x32 and 96x96.

@asaadmahmood is this something you'd be able to help provide for @jkl5616?

[jkl5616]

@mkraft @amyblais Does this issue need more additional work?

[amyblais]

@jkl5616 We made a decision to revert the original feature PR from v5.14 because it was causing this bug: https://mattermost.atlassian.net/browse/MM-17618. We are too close to v5.14 release day to have time to fix the bug at this point.

[jkl5616]

@amyblais Okay, then can I handle this as I am the original contributor of that PR?

[amyblais]

Sounds good, thank you.

[hmhealey]

FYI, we decided that this feature should only be supported on Chrome and Firefox since we've ran into issues with consistency when changing the favicon on Edge and Safari. I've updated the ticket description to reflect that

[hmhealey]

Hi @jkl5616. Are you still working on this? Is there anything we can help with?

[larkox]

May I take this one?

[jasonblais]

@larkox Go for it! As you can see above, there have been a couple of PRs opened previously that were closed, I'd propose reviewing them first to see what outstanding items there were.