Mattermost-server: [Help Wanted] [MM-11860] Expose slack attachment parsing functions in the model package

Created on 27 Aug 2018  路  5Comments  路  Source: mattermost/mattermost-server

If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Developer's Guide, specifically for machine setup and for developer workflow.


Notes: Jira ticket

Plugins use Slack attachments all the time to better render posts. We have some functions in the app package used for parsing and processing them. Refactor those functions into the model directory so that plugins have access to them.

These two functions in particular:
https://github.com/mattermost/mattermost-server/blob/master/app/post.go#L312

If you have any questions or would like feedback, feel free to ask in the Developer Toolkit channel on our Mattermost community instance.

Easy TecGo

All 5 comments

I'd be interested in taking a crack at this. I'm new to Golang and Mattermost development though.

Awesome, thanks @cjbirk! Feel free to reach out to us for guidance if needed.

I have code ready to merge but I'm not certain about the "Checklist" section of the PR guidelines. I don't see any option for 'code refactoring' and I don't think this is really a feature addition? Please let me know if I'm OK to submit this with a blank checklist.

I wrote a plugin to test this.. I can perhaps link to that in the PR?

@cjbirk You can submit it following the PR template and removing the checklist items that don't apply to your changes.

Thanks @cjbirk!

Was this page helpful?
0 / 5 - 0 ratings