Mattermost-server: [Help Wanted] [MM-9686] Add unit tests for channel routing
If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.
New contributors please see our Developer's Guide, specifically for machine setup and for developer workflow.
Notes: Jira ticket
The new channel routing behaviour was added, but it's not covered by unit tests. It should have unit tests added and possibly be refactored to be more easily testable.
The code for channel routing is in here. The easiest way to make it testable would probably be to separate the logic for rewriting the URL and for setting the current channel ID, and then to test those independently.
esethna
All 5 comments
@sudheerDev is working on it
jwilander
on 28 Mar 2018
This is not introductory though or did I make it complex than it seems!!
sudheerDev
on 3 Apr 2018
@sudheerDev Maybe I added the wrong label -- I've updated although let me know if I should bump it up further.
jasonblais
on 3 Apr 2018
@jasonblais that's ok. just surprised to see it as introductory. Anyway, I overdid in the PR!
sudheerDev
on 3 Apr 2018
Closing this since that code may be changing soon
hmhealey
on 13 Nov 2018
Related issues
esethna
路
3Comments
tumbl3w33d
路
3Comments
Pomax
路
3Comments
esethna
路
3Comments
esethna
路
3Comments
Most helpful comment
@sudheerDev is working on it