Mattermost-server: [Help Wanted] Migrate delete_post_modal.jsx to be pure and use Redux

Created on 19 Oct 2017  路  6Comments  路  Source: mattermost/mattermost-server

If you're interested please comment here and come join our "Redux" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team.

New contributors please see our Redux contribution process to help get you started.


Difficulty: Intermediate

Details: Mattermost is moving their webapp to Redux over the next months and we're looking for contributors to help with that effort. This Help Wanted issue is to move components/delete_post_modal.jsx to Redux.

Before submitting the pull request, make sure it has proper component testing as described here.

For a sample pull request for migrating a component to use Redux, see https://github.com/mattermost/platform/pull/6416

Medium TecReactJS TecRedux

Most helpful comment

Hi,
We have been looking into this component and would like to try and tackle it.
While looking at the current implementation we had a few questions:

  • Currently there is a function in global actions that toggles the delete modal. Is it right to assume that instead we should use the openModal action? Like what was done here?
  • Non of us have migrated components from Flux to Redux before. Is there something we need to look out for?

We are a group of four students, who are currently taking a course to study open source projects.
My teammates are: @cooltomatos @lmikaellukerad @XinyueWang94

All 6 comments

Hey, I am interested in working on this!

Awesome, thanks @lpan!

I have to study for midterms this weekend :cry: will start working on it next Thursday (October 26) :stuck_out_tongue:

Hey @lpan, totally understand! Fine to start on this next week.

Good luck with your midterms! :)

Hi,
We have been looking into this component and would like to try and tackle it.
While looking at the current implementation we had a few questions:

  • Currently there is a function in global actions that toggles the delete modal. Is it right to assume that instead we should use the openModal action? Like what was done here?
  • Non of us have migrated components from Flux to Redux before. Is there something we need to look out for?

We are a group of four students, who are currently taking a course to study open source projects.
My teammates are: @cooltomatos @lmikaellukerad @XinyueWang94

Hi @GitHubJasper,

  1. Yes that would be the right way to open the modal
  2. I'd take a look at https://docs.mattermost.com/developer/webapp-to-redux.html and then if you have any specific questions let us know here or on our Mattermost instance
Was this page helpful?
0 / 5 - 0 ratings