Mattermost-server: [Help Wanted] [PLT-7803] Have shift+up switch keyboard focus to RHS if it's already open to the current thread

[esethna]

If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Developer's Guide, specifically for machine setup and for developer workflow.

---

Notes: Jira ticket

Repro steps:
1) Press shift+up to open the latest thread in the channel in the RHS
2) Click into the post textbox
3) Press shift+up again

Observed: Nothing happens
Expected: The keyboard cursor moves to the RHS which is already open

[d1ndra]

I would like to work on this, any help would be appreciated.

[jasonblais]

Thanks @d1ndra! A good place to start is to review our Developer's Guide, specifically for machine setup and for developer workflow.

[jasonblais]

Let us know if you have any questions :)

By the way, this pull request originally added the shortcut, which might be helpful: https://github.com/mattermost/mattermost-server/pull/6549

[d1ndra]

Thanks @jasonblais

[d1ndra]

@jasonblais from my understanding, to shift the focus back to the already open RHS one would have to invoke the componentDidUpdate in create_comment.jsx, however since the state is the same there is no updating. Performing a this.forcedUpdate() also only invokes the method in create_post.jsx. Any advice on how to proceed? Thanks

[jasonblais]

Thanks @d1ndra, you got a response in the Developers channel: https://pre-release.mattermost.com/core/pl/6e18z4b9m7g4zxy8oztnwd9uce

Thanks for working on this issue!

[jasonblais]

@d1ndra Let us know if you have any other questions on this ticket?

[esethna]

Reopening this ticket if anyone is interested in taking it on

[lisakycho]

I'm going to take this issue.

[jasonblais]

Great, thanks @lisakycho :tada: