Mattermost-plugin-github: Proposal: Add icon for build status on the open PRs

Created on 12 Dec 2019  路  8Comments  路  Source: mattermost/mattermost-plugin-github

Maybe two icons, one red one green with a number. Clicking that icon will open LHS with the PRs that are either green or red

Medium Help Wanted TecReactJS

All 8 comments

@reflog Are you proposing to have two icon on the LHS or the RHS?

RHS, similar to the icons we already have, one for broken builds one for passed

Maybe we should the icons right next to the name similar how GitHub does it
Screenshot from 2019-12-22 20-40-41

Screenshot from 2019-12-22 20-41-20

Grr. Sorry, I meant LHS for my icons. But your idea for RHS is great too. Not mutually exclusive :)
I meant something like (sorry for my amazing UI skills):
image

Good that talked about this :wink:

Actually, I would push back on adding this to the LHS. If a user is not part of a team, the icon is shown under the username. But there isn't enough space for more icon.
Screenshot from 2020-01-08 14-23-02

Hence, I propose to only show an icon next to the PR name on the RHS. Let me know what you think @reflog.

That definitely makes sense. I didn't consider the horizontal layout

@hanzei, @reflog Correct me if wrong, but the RHS implementation was merged in this PR https://github.com/mattermost/mattermost-plugin-github/pull/170. Assuming LHS will be left alone, can we close this issue?

Good catch @jfrerich, closing

Was this page helpful?
0 / 5 - 0 ratings