Matterbridge: [Enhancement Request] Edited messages should edit across supported bridges

[jheiselman]

If you have a configuration problem, please first try to create a basic configuration following the instructions on the wiki before filing an issue.

Please answer the following questions.

Which version of matterbridge are you using?

0.16.2-dev

If you're having problems with mattermost please specify mattermost version.

NA

Please describe the expected behavior.

When a message indicates that it's an edited message and it is being forwarded to a platform that supports message editing, then it should edit the original message

Please describe the actual behavior.

A new message is created instead of editing the original message

Use logs from running matterbridge -debug if possible.

Any steps to reproduce the behavior?

Please add your configuration file

(be sure to exclude or anonymize private data (tokens/passwords))

[jheiselman]

I'm not sure how possible this is without using something sort of data store to keep track of messages, but I thought I'd start a discussion about it.

Discord messages have an edited_timestamp property that contains a non-null value if the message has been edited.

Slack messages have an edited property if they have been edited. Otherwise, the property will be missing.

[42wim]

Yes, this would mean matterbridge will have to keep state (the api bridge already does this though in memory in a circular buffer).

But if you edit a message in the past that mattermost/slack/discord hasn't seen yet, it will not work.
This is something nice to have, but not feasible for me in the short term. Could be a december project though.

As always PR's / discussions about this are welcome.

[42wim]

Ok, this is happening, mattermost <=> discord already works locally, not yet commited to master.

[42wim]

@jheiselman @jleclanche

The current code (also binaries can be found on https://bintray.com/42wim/nightly/Matterbridge/_latestVersion) adds support for in place editing of message send to gitter, discord, mattermost, telegram and slack.

The only exception here is that edits made by a gitter user aren't relayed because gitter doesn't relay edits in the streaming api. Message sent to gitter (eg from discord) and edited on discord while appear also edited on gitter.

Also, matterbridge can only edit messages that are done while matterbridge is running. It doesn't edit messages created at the time matterbridge wasn't running.

Testing and feedback are appreciated.