Mathjs: Breaking changes for v6

Created on 6 Jun 2018  路  8Comments  路  Source: josdejong/mathjs

  • [x] Remove generated files from the git repo
  • [x] Drop support for node version 6 (#1494)
  • [x] Remove redundant "use strict" (#1473)
  • [x] Group and cleanup all folders in the root of the repo
design decision

Most helpful comment

Good idea. The markdown files in /docs are generated and the website should be enough for this. The embeddedDocs are not auto-generated, we should keep them. In the modular_architecture branch there are currently still some index files which are half-auto generated. As soon as that's fully auto generated we can remove them too from the repo.

All 8 comments

May I suggest that we remove all generated files from github for version 6? This will reduce the size of the repository and make contributing more intuitive. Is also good git practice.

In practice this would be some of /docs and maybe also embeddedDocs (or are these handwritten?).

Good idea. The markdown files in /docs are generated and the website should be enough for this. The embeddedDocs are not auto-generated, we should keep them. In the modular_architecture branch there are currently still some index files which are half-auto generated. As soon as that's fully auto generated we can remove them too from the repo.

Updated to make note of dropping node 6.

One last request for v6: we have a lot of testing related directories in the top level of mathjs. (A large fraction of them put there by me.) If I can find a way to consolidate them into one (or maybe two) directories I think it would make the mathjs repo easier to use.

Thanks a very good idea Harry!

Here an idea:

from | to
----| ----
test | test/unit-tests
test-generated | test/generated-code-tests
test-node | test/node-tests or test/integration-tests
benchmark | test/benchmark
browser-test-config | test/browser-test-config
img | misc/img
es5 | main/es5
es6 | main/es6
composer.json | drop it?

Looks perfect!

Ok I will move the directories around and update the build scripts.

The folders are reorganized now.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

balagge picture balagge  路  5Comments

skgadi picture skgadi  路  3Comments

Lakedaemon picture Lakedaemon  路  5Comments

balagge picture balagge  路  3Comments

piotr-s-brainhub picture piotr-s-brainhub  路  3Comments