Materialize: Scrollspy target is not accurate anymore (0.96.0)

[vincentmorneau]

Self-explanatory, see screenshot:

There is a big gap when clicking on any Scrollspy link.

[Dogfalo]

It is actually meant to be like that so the item is more centered and will not conflict with any type of fixed header.

[vincentmorneau]

Thank you for the answer. Unfortunately I don't think it is natural or intuitive. I will look for a way to bring it back below my fixed header.

[Dogfalo]

We will add it in as an option
On Apr 3, 2015 1:51 PM, "Vincent Morneau" [email protected] wrote:

Thank you for the answer. Unfortunately I don't think it is natural. I
will look for a way to bring it back below my fixed header.

—
Reply to this email directly or view it on GitHub
https://github.com/Dogfalo/materialize/issues/1080#issuecomment-89374089
.

[TheAdamGalloway]

Any idea how one would fix this? It's essentially ruined the relative links on our frontpage.

[TheAdamGalloway]

Fixed it... For anybody who was wondering, you must change the ScrollTop option for scrollspy in the javascript file.

[vincentmorneau]

Yup. As of 0.96.0, I had to put these values in comment in scrollspy.js :

Works perfectly, until Dogfalo adds it as an option.

[whoiskjl]

I'm glad that this has been mentioned. How about a callback option? instead of scrollfire. Because I want to fire callbacks more than once.

[RichardLindhout]

+1 add this as an option! Thanks @vincentmorneau and @TheAdamGalloway!

[filippolcr]

Thanks Saved My life!

[limzykenneth]

I'm using the materialize ruby gem so editing the JS is not really an option for me. Any idea what can I do?

[TheAdamGalloway]

Over a year on, this is still an issue for me. I have to edit the JS file each time I update.

[vincentmorneau]

@TheAdamGalloway Me too...

[gratcliff]

Thanks for the tips guys! Worked perfectly :)

[NitroBAY]

What do you think of my PR ?

[kmmbvnr]

Yeah, I never was able to use ScrollSpy.

Fixed in https://github.com/Dogfalo/materialize/commit/696bfc4868954340e355879b6a73f9df7c4b85aa

[TheAdamGalloway]

Looks good to me, @NitroBAY