Materialize: New List Feature

Created on 22 May 2017 · 12Comments · Source: Dogfalo/materialize

Hi, everyone!

I'm working on a new feature and I'm almost done. Wondering if I should finish off (organise sass and such) and submit a pull request or if I've missed anything.

Thanks for the help!

Source

penguoir

👍1

Most helpful comment

I think it would be a good idea to integrate lists as I implemented them and slowly deprecate the collections component.

penguoir on 26 May 2017

👍2 🎉1

All 12 comments

@DanielRuf this looks good to me on mobile, but can you have a look at this and give some feedback too?

tomscholz on 22 May 2017

I just realised that collections is really similar to this.

penguoir on 22 May 2017

@penguoir but lists as you implemented are still missing, see https://github.com/Dogfalo/materialize/issues/4553

DanielRuf on 22 May 2017

@penguoir I think collections are a little bit out of scope from the material design spec. Maybe you could rewrite the collections with your lists. I really think this could fit into this framework

tomscholz on 23 May 2017

Cool. Is there a specific way to add a component to the framework?

penguoir on 23 May 2017

It's recommended to fork Msterialize, create a new feature branch, add the files in sass/ and js/ and docs in /jade, add the files to the Gruntfile, test locally and push it to GitHub and open a new pull request for this.

DanielRuf on 23 May 2017

I've made the pull request

penguoir on 26 May 2017

👍1

I think it would be a good idea to integrate lists as I implemented them and slowly deprecate the collections component.

penguoir on 26 May 2017

👍2 🎉1

I think it would be a good idea to integrate lists as I implemented them and slowly deprecate the collections component.

Agreed. It's a little confusing that it is currently called collections when the Material Design spec refers to lists. It's also a good idea to deprecate so that existing sites or libraries that depend on Materialize have time to adjust.