Materialize: $.fn.autocomplete conflicts with many frameworks like jQuery.ui

Created on 21 Apr 2017  路  5Comments  路  Source: Dogfalo/materialize

Description

The name of the function conflicts with similar functions or other frameworks, like for instance tinyMCE or jQuery UI, as $.fn.autocomplete is too generic and should be changed to materialize_autocomplete

Repro Steps

Load materialize forms.js within any form with also the jQuery UI or tinyMCE libraries, then call the autocomplete for another framework, and it will crush because it has the same function name, but other functions expects different parameters.

Just call it in another way to make it compatible with many more apps.
Thanks!

Autocomplete has-pr thirdparty

Most helpful comment

@qantumthemes I agree with you

All 5 comments

@qantumthemes I agree with you

Thanks @fega :) it took me about half hour to find the issue, what I don't understand is why the function was not already prefixed as instead $.fn.material_select which is the one right after the autocomplete.

I truly love Materialize and I use it for everything, so I just want to suggest a small improvement to increase the compatibility with the rest of old and consolidated js around.

Thanks!

See #4574

Autocomplete was been rewritten in alpha v1.0.0. You can also use the native javascript init to bypass any conflicts.

Was this page helpful?
0 / 5 - 0 ratings