Material: chips: regression to component focus in 1.1.2

Created on 1 Feb 2017  路  18Comments  路  Source: angular/material

Actual Behavior:

  • md-chips focus is being applied only inside md-chip-input-container
  • Focus should be there through out the md-chips

Angular Versions: *

  • Angular Material Version:1.1.3
- Lots of Comments urgent Pull Request fixed regression bug polish

Most helpful comment

This is a serious usability bug... how is this being overlooked? +1

All 18 comments

How are you setting focus to it?

@cmacdonnacha Still I have not done. Concerned party has to fix the code. Previously in angular material version: 1.1.1 it was working fine while in v1.1.3, they might have missed to add md-focused on md-chips-wrap when a click is made on it.

v1.1.1: https://material.angularjs.org/1.1.1/demo/chips
v1.1.3: https://material.angularjs.org/latest/demo/chips

@sivakrrish1994 I ran into a similar issue. Trying having a look at my last comment on this issue:

Seeing the same thing. To clarify on the issue, if you click on the far right of the chips component (a part of it that doesn't have the chip-input-container directly under your click) in the 1.1.1 docs, the chip-input-container will be focused, while the same action in 1.1.3 docs does nothing.

ya @cmacdonnacha that's one of the option but literally this functionality needs to be implemented by the material team.
Let us wait for the material team to fix this issue @cmacdonnacha @tyrdavis

+1 for this feature

Till then any workaround would be appreciated.

This is a serious usability bug... how is this being overlooked? +1

Same here, 馃憤

Sorry @matteomartinelli, it鈥檚 time to fork it. They stopped development on it ages ago. But it鈥檚 worth using!

What's the difference between 1.1.1 and 1.1.3+? In addition the the click on right side not triggering the focus, you will also notice that the placeholder text is truncated because default input box is not wide enough to show the full placeholder text.

Workaround CSS using flex layout.

.md-chips {
  display: flex;
  flex-flow: row wrap;
  box-shadow: none;
}
/* make input box full width of md-chips */
 .md-chip-input-container {
  flex: 1 1 auto;
}

Verified that this was introduced in 1.1.2 (as part of https://github.com/angular/material/pull/9650). Will have a PR up for this soon. It takes a better approach than #11082.

The PR ran into some presubmit failures on internal Google tests. I will see about trying to get it into 1.1.8.

Hello. Any news on when the fix for this will be released?

wouldnt hold my breath. It鈥檚 time to fork!

馃う

hi anybody got a solution for this?

PR https://github.com/angular/material/pull/11098 has been updated and re-submitted to presubmit. It's targeted at 1.1.10.

Was this page helpful?
0 / 5 - 0 ratings