Actual Behavior:
What is the issue? *
What is the expected behavior?
I believe that the same problem may be happening in other places like here:
https://github.com/angular/material/blob/dfc9ae7331c2a23552045a4c7baef02ee5d1bc10/src/components/list/list.scss#L62
CodePen (or steps to reproduce the issue): *
CodePen Demo which shows your issue:
Details:
Angular Versions: *
Angular Version:
1.5.5Additional Information:
Browser Type:
ChromeStack Traces:
Shortcut to create a new CodePen Demo.
Note: *
indicates required information. Without this information, your issue may be auto-closed.
Do not modify the titles or questions. Simply add your responses to the ends of the questions.
Add more lines if needed.
here is my pull request to fix this issue.
https://github.com/angular/material/pull/10491
Looking at the Material Design spec for Chips, this remove icon should not be using the Close icon as it is now. It should be using the Cancel icon instead. Also the icon should have an opacity of 0.54
. And it should have some additional margins to the left and right.
This CSS seems to get as close to the spec as possible.
min-width: 18px;
min-height: 18px;
position: absolute;
margin: 0 0 0 4px;
opacity: 0.54;
This would also require changing https://github.com/angular/material/blob/master/src/components/chips/js/chipsDirective.js#L365 to:
mdChipsCtrl.mdCloseIcon = $$mdSvgRegistry.mdCancel;
Let's try to get the icon sizing fixed in the existing PR and then tackle the rest of this in another issue/PR.
This breaking CSS change was part of the 1.1.0 minor release as the CSS is changed from what was in 1.0.9. As this was a minor release, breaking CSS changes like this were acceptable. Additionally, we'll need to wait for another minor release (1.2.0) before this can be fixed since it is a breaking visual change via CSS.
Most helpful comment
here is my pull request to fix this issue.
https://github.com/angular/material/pull/10491