Material-ui: [Breadcrumbs] Inconsistent "aria-label" instruction and example

Created on 10 Feb 2019  路  3Comments  路  Source: mui-org/material-ui


The documentation section for Breadcrumbs state the following (under "Accessibility"):

Be sure to add a aria-label description on the Breadcrumbs component.

However, in the actual code demos for Breadcrumbs, the property used is "arial-label". Possible typo? If so, probably the result of copy/paste

  • SimpleBreadcrumbs demo: Lines 29 and 41
  • CustomSeparator: Lines 31, 43, 55,
  • etc...

  • [x] This is not a v0.x issue.

  • [x] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior 馃

Code in demos should say <Breadcrumb aria-label="Breadcrumb">

Current Behavior 馃槸

Code in demos say <Breadcrumb arial-label="Breadcrumb">

Steps to Reproduce 馃暪

Look at the code of any demo in Lab/Breadcrumbs

Your Environment 馃寧

| Tech | Version |
|--------------|---------|
| Material-UI | v3.9.2 |

bug 馃悰 Breadcrumbs docs good first issue

Most helpful comment

@umairfarooq44 I would be happy to review it :).

All 3 comments

@MalignantShadow Yes, it's definitely a typo. We should be using aria-label in the demos. Do you want to fix it? :)

@oliviertassinari I would like to make PR. You can assign me. Thanks

@umairfarooq44 I would be happy to review it :).

Was this page helpful?
0 / 5 - 0 ratings