Material-ui: Hosted devel version v3.1.0 produces "require not defined"

[Verikon]

Hosted v3.1.0 (https://unpkg.com/@material-ui/core/umd/material-ui.development.js) produces "require not defined"

Previous v3.0.3 did not do this.

I simply changed our link to the previous version:

<script src="https://unpkg.com/@material-ui/[email protected]/umd/material-ui.development.js"></script>

[oliviertassinari]

@TrySound I have updated all the rollup dependencies, could it be linked?

[TrySound]

Just never use commonjs explicitly.

https://github.com/mui-org/material-ui/blob/master/packages/material-ui/src/styles/withStyles.js#L226

[TrySound]

This micro optimization should be done by bundler, not developer.

[TrySound]

You should specify only production/development usage. Bundler (smart bundler) will eliminate unused stuff.

[oliviertassinari]

@TrySound Thanks for looking into it! I'm removing the require call. But why is it not handled by rollup? Is there is some es module on/off mode that prevents it to handle require once he sees an export/import?

[oliviertassinari]

@Verikon Will be fixed in v3.1.1 this weekend.

[TrySound]

Rollup handles only ESM. Consider CJS doesn't exist with it (except commonjs plugin for node_modules).