Material-ui: UMD package: export MaterialUI variable

[tkrotoff]

Currently to use Material-UI with codepen.io, JSFiddle... you have to write (see https://stackoverflow.com/q/50705423):

const { Button, Input } = window['material-ui'];

This is because the output name inside rollup.config.js is 'material-ui':
https://github.com/mui-org/material-ui/blob/8013fdd36d40980ebb8f116f20e2843b781c0c39/packages/material-ui/scripts/rollup.config.js#L10

Instead it should be a name without -, something like 'MaterialUI':

const { Button, Input } = MaterialUI;

rollup.config.js example:

https://github.com/tkrotoff/react-form-with-constraints/blob/b64119bee6ab80c77417a9284a704b380b81bf5e/packages/react-form-with-constraints/rollup.config.js#L19-L27

Related issue: #7621

[oliviertassinari]

@tkrotoff This change sounds good to me. However, it's a breaking change. We gonna need to bump the version to v2. I'm adding it into the milestone 👍

[tkrotoff]

This use case is OK: codepen.io => material-ui (with window['material-ui'])
This use case is KO: codepen.io => myLib => material-ui

I don't know how to configure myLib to use window['material-ui'] (no problem of course if material-ui exported a variable MaterialUI).
It's probably not possible, so having a MaterialUI export is not only a "nice to have".

Example code:

• react-form-with-constraints-material-ui ("myLib") umd: https://unpkg.com/[email protected]/dist/react-form-with-constraints-material-ui.development.js
• react-form-with-constraints-material-ui rollup.config.js: https://github.com/tkrotoff/react-form-with-constraints/blob/a742293a3ef16806aaae98f4254a521a6ce196a4/packages/react-form-with-constraints-material-ui/rollup.config.js#L24-L27
• codepen.io experimentations: https://codepen.io/tkrotoff/pen/MBGOQo

[oliviertassinari]

I don't know how to configure myLib to use window['material-ui']

@tkrotoff We will definitely move forward and address this problem in v2!

[tkrotoff]

@oliviertassinari wow did not expect a release so soon! Can I make a PR to change this: https://github.com/mui-org/material-ui/blob/v3.0.0/packages/material-ui/scripts/rollup.config.js#L10 ?

[oliviertassinari]

@tkrotoff What do you mean? This change is still planed for v4, in 3-4 months.

[tkrotoff]

Je suis un peu perdu : few days ago you were talking about a v2. I saw v3 was just released (could have been a good time to change this) and now talking about a v4.
Anyway, can I make a PR on master? (I guess not, master is for v3 and there is no branch for v4 yet).

[oliviertassinari]

Yeah sorry for the confusion. v2 focus has just shifted to v4 for Q1 2019.

[oliviertassinari]

You can definitely open a pull request now on master. We will just wait before merging it :).