Material-ui: Add a touchRippleClasses property to the ButtonBase component

Created on 27 Feb 2018  路  6Comments  路  Source: mui-org/material-ui

I have been looking for a solution to be able to customize the touchRipple color and I think this is the best solution that fits the coding style of material-ui.

ButtonBase enhancement good first issue

Most helpful comment

Should I make a pull request? That would be my first one so it may not be the perfect pull request... :)

All 6 comments

What about adding a TouchRippleProps property in the ButtonBase component?

Even better, but then we should consider removing centerRipple prop.

then we should consider removing centerRipple prop

I don't think so, TouchRippleProps is here so people can hack around. centerRipple is a property that is useful on it's own. People shouldn't be concern about the implementation detail of this property.

Makes sense! 馃憤

Should I make a pull request? That would be my first one so it may not be the perfect pull request... :)

@christophediprima This would be great :).

Was this page helpful?
0 / 5 - 0 ratings

Related issues

revskill10 picture revskill10  路  3Comments

ghost picture ghost  路  3Comments

rbozan picture rbozan  路  3Comments

pola88 picture pola88  路  3Comments

ryanflorence picture ryanflorence  路  3Comments