Material-ui: [TableCell] Add `centered` as flag?

[the-noob]

We already have numeric for left alignment, it would be nice to have centered/center too as a quick flag as, I think, centering is quite a common requirement.

[oliviertassinari]

In that case, what about introducing an align property to replace the numeric one?

[the-noob]

It certainly makes sense but my only concern is from a what is gained perspective.
I mean the usage would be align="left" or align="center" ... which is not far from "className={classes.center}" (from a keystroke perspective).
Maybe have 3 flags - left', center and right ?

[oliviertassinari]

Maybe have 3 flags - left', center and right ?

This introduces degree of freedom that can lead to unexpected behavior. Someone can set left and right at the same time without noticing. What should be the output in this case?

[oliviertassinari]

I have added the waiting for users upvotes tag. I'm closing the issue as I'm not sure people are looking for such abstraction. So please upvote this issue if you are. We will prioritize our effort based on the number of upvotes.

[tendermario]

I agree with an align key. numeric can override the align key if necessary - or even be a value for align. "left", "center", "right", "numeric"

I think this feature is still worth adding in. I also agree that multiple boolean keys competing for priority doesn't make sense if we don't intend to be able use them at the same time. align="center" vs center is quite minor.

[oliviertassinari]

I think that it would be better to add an align property we have in the Typography component instead of a centered as flag:

align?: PropTypes.Alignment; // 'inherit', 'left', 'center', 'right', 'justify'

However, I'm wondering if we can't solve this problem with a generic helper that can be shared between the different core components.

[IssueHuntBot]

@issuehuntfest has funded $40.00 to this issue. See it on IssueHunt