Hello,
Thanks for this nice project.
Breadcrumb component would be nice for extra navigation.
http://demo.geekslabs.com/materialize-v1.0/ui-breadcrumbs.html#!
Thank you.
As far as I know, there is no breadcrumbs into the official material specification. It's not present into our tracked list of components. Let's keep the focus on our core mission.
I would like to revisit this issue. @mui-org/core-contributors What do you think of supporting such component? Maybe we can do something very simple. Here is a sample by @simoami:
https://codesandbox.io/s/qkvzlx47x9
Here is vuetfiy version: https://vuetifyjs.com/en/components/breadcrumbs#introduction
I would rather focus on components that are in the spec and not (fully) implemented.
Concerning Breadcrumbs I think we can create some utility component that joins it's children with a given separator and also use that for Stepper i.e. Array.prototype.join
for components.
I've taken a first pass at bringing @simoami's Breadcrumbs component into the lab, and moving towards Material-UI code conventions:
No tests or types yet, but I can look into extracting the utility component that @eps1lon suggested, to be used by both Breadcrumbs and Stepper.
@mbrookes It looks great 馃槏 !
@mbrookes Looks great! Let me know if there's anything I can do to help.
Hi - is there any time frame for when this will be included in the lab?
@DrewBe121212 Apologies - real life got in the way the last few weeks. I'm away next week, but might get some time here or there to look at it again, otherwise it's likely going to be during Christmas.
No worries! Totally understandable! You don't happen to have it pushed into a branch anywhere do you? I have a use case for it and wouldn't mind putting it through its paces. If not, no worries as well. I'll have to implement my own version till then.
Not yet there. Any idea? Or should we go with other external package?
@DrewBe121212 So sorry, I missed your last comment among the deluge (I don't know how @oliviertassinari manages to keep up!) I've just pushed the branch: https://github.com/mbrookes/material-ui/tree/lab-breadcrumbs
This might give you the diff (not sure if it works for other users: https://github.com/mbrookes/material-ui/pull/new/lab-breadcrumbs)
@mukarramali-tw No, sorry, I took some time out over Christmas to focus on family, as my day job (not MUI) was getting overwhelming; and now I'm prepping for interviews...
If someone else wants to pick this up to continue to clean it up, and to add types & tests, feel free to jump in; otherwise, I haven't forgotten it, I just need to get some other stuff sorted first to try to hopefully free up some time to commit to Material-UI.
@simoami Thanks for kick-starting the effort! 馃憤
Woohoo! Glad it made it to an official release! Thanks @mbrookes and @oliviertassinari for taking it to the next level.
Most helpful comment
I've taken a first pass at bringing @simoami's Breadcrumbs component into the lab, and moving towards Material-UI code conventions:
No tests or types yet, but I can look into extracting the utility component that @eps1lon suggested, to be used by both Breadcrumbs and Stepper.