Material-ui: Migrate all dependencies to react@16

Created on 22 Oct 2017  路  6Comments  路  Source: mui-org/material-ui

We are almost there. The only part missing is the test suite, 1200+ tests to migrate 馃槺.
It's going to be painful but let's do it! 馃挭

external dependency

Most helpful comment

@leMaik I should manage to upgrade to enzyme@3. Only 4 more failing tests to fix. Then we are going to have to wait for portal support.

All 6 comments

@oliviertassinari What exactly needs to be migrated? Would you mind creating a TODO list to let us know where we can help you? :+1:

I still have 110 tests that are red and need to pass. The biggest blocker seems to be related to Portal https://github.com/airbnb/enzyme/issues/1150. By migrated, I simply mean making the tests green.

I will push the branch as far as I can. But I will most likely not be able to complet it. This is my third iteration on the topic. If I fail, I will simply retro port the changes with react@15 so we move forward, one step at the time.

@oliviertassinari Enzyme not supporting portals is a somewhat major blocking issue. I don't really get why nobody over there seems to bother about it. :confused:

@leMaik I should manage to upgrade to enzyme@3. Only 4 more failing tests to fix. Then we are going to have to wait for portal support.

I'm gonna resume the effort. I'm gonna try to code branch the portal code for the tests. It might reduce the test coverage but it should allow us to close this issue.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

anthony-dandrea picture anthony-dandrea  路  3Comments

mattmiddlesworth picture mattmiddlesworth  路  3Comments

FranBran picture FranBran  路  3Comments

activatedgeek picture activatedgeek  路  3Comments

ryanflorence picture ryanflorence  路  3Comments