Material-ui: 1.0.0 Themes not fully toggled

[foureggs]

Problem description

When you go to the official 1.0.0 documentation there is an issue with the theming button. Press it twice yourself to see that the white theme does not toggle everything. This could possibly be a problem with the docs but you should make sure that this is not a problem with the material-ui version itself.

Link to minimal working code that reproduces the issue

the official 1.0.0 documentation

Versions

• Material-UI: 1.0.0
• React: 15.5.4
• Browser: Chrome, Firefox, possibly others as well

Images & references

-->

[oliviertassinari]

@nathanmarks I remember we mentioned that issue a while ago. Any idea, or tips to address this issue 💡 ?

[nathanmarks]

@oliviertassinari I have to look and see if this is an issue with theme reactor or with context updates in the docs.

[foureggs]

It seems like it's a problem with material-ui not the docs. Here is a problem I have encountered after a transition from 0.17 to 1.0.0. Notice the bottom right corner when at first, the button is yellow but after switching to it again, it becomes grey.

Hope it helps. 👍

[oliviertassinari]

@foreggs Do you have any pure render logic on your app?
As far as I'm aware of, we don't have any pub-sub system allowing use to bypass a blocking pure render logic.

[foureggs]

@oliviertassinari I don't fully understand your question. I am using a simple redux store and a mui theme provider that uses the theme from the store.
I am using the react.component all the way, no PureComponents have been used. The mui theme should rerender entirely when its props change so this error should be present. I also want to mention that this method works with 0.1.7.

I'll reproduce the error on webpackbin tomorrow and add reference to it if I don't forget.

[nathanmarks]

Gonna look at this tonight. I'll see if the issue is with theme-reactor.

@oliviertassinari I'm wondering if we should use a pub-sub system in theme reactor instead. WDYT?

[nathanmarks]

@oliviertassinari Or at least have the option to? hmm

[nathanmarks]

Ok I found the theme toggling issue in the docs btw, to do with how we're updating the theme.

We're creating a new stylemanager instead of updating the existing, and not canning the old sheets.

[nathanmarks]

Hmmm. Can't fix it just by resetting the old styleManager when App re-renders because the SVG icons don't re-render. Hmmm.

[foureggs]

@nathanmarks I am pretty sure this is a problem with the material ui core in some cases. Demo