Material-ui: [FlatButton] (and all buttons) lacks target property

Created on 25 Oct 2016  路  5Comments  路  Source: mui-org/material-ui

Problem description

You can specify an href for buttons, but you can't specify a target (ie target="_blank"), so you still need to write extra code if you want a button to open a separate tab (ie for a help button)

IconButton good first issue

All 5 comments

From the Tabs/Tab official documentation, there is _Controlled example_ showing how to switch between tabs programmatically, setting the Tabs.state.value referencing each Tab.

I doubt adding a target prop to Tab would change anything, and kinda anti-pattern.

Hey @toddmedema, thanks for openning an issue!

I think the issue here is aiming tabs on a browser environment, @Sharlaan, not the component itself.

I think this is a valid feature request and also a good first issue, we would be glad to review a PR for it!

I have just merged #5491 documenting where the no listed properties are going to be applied.
E.g. the target property is going to be applied to the root element. I don't think that we should be adding target explicitly in the docs as the list of interesting properties we could add is very long. I would rather educate users regarding this general behavior on all the components.

Should this be closed? I see jvhoven submitted a PR that does exactly what this issue describes.

Thanks for the reminder.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

iamzhouyi picture iamzhouyi  路  3Comments

anthony-dandrea picture anthony-dandrea  路  3Comments

ghost picture ghost  路  3Comments

finaiized picture finaiized  路  3Comments

reflog picture reflog  路  3Comments