Material-ui: [AppBar] Port component

Created on 22 Jul 2016  路  7Comments  路  Source: mui-org/material-ui

  • [x] Component
  • [x] Tests (at least unit tests)
  • [x] Docs
  • [x] Demo
AppBar

Most helpful comment

Im interested in the issue #5478 about having a Google Inbox style text field in the center of my app bar, what do the changes to AppBar mean for this?

I wouldnt mind using the Title property for doing it, but then if I want a title there, Id have to manually copy the h1 element with all its style properties which feels a little too dirty for my liking.

Perhaps it might be good to have something along the lines of elementCenter or something to allow you to put elements in the middle of an app bar?

All 7 comments

Started, needs a little more work. @newoga any desire to implement some of your experiments? Or best to wait and keep it simple?

Will porting the AppBar also be a step towards making it more composable, or is this just a 1:1 feature set port?

@mtrpcic A basic (and much more composable) AppBar is already in the next branch (https://github.com/callemall/material-ui/blob/next/src/AppBar/AppBar.js). It's fairly easy to implement an AppBar with a similar API in older version of material-ui too.

@newoga any desire to implement some of your experiments? Or best to wait and keep it simple?

Sorry @nathanmarks! Didn't see that mention before. Yeah I'd be interested though as I have time probably makes sense to keep this component simple and work on porting other components.

@newoga Thanks for the info!

Im interested in the issue #5478 about having a Google Inbox style text field in the center of my app bar, what do the changes to AppBar mean for this?

I wouldnt mind using the Title property for doing it, but then if I want a title there, Id have to manually copy the h1 element with all its style properties which feels a little too dirty for my liking.

Perhaps it might be good to have something along the lines of elementCenter or something to allow you to put elements in the middle of an app bar?

@mbrookes @oliviertassinari Isn't it ported already and can be closed?

I think perhaps it was being kept open pending any refinements that @newoga had been working on. I think we can close it for now.

Was this page helpful?
0 / 5 - 0 ratings