Please try the example here : https://github.com/adhbh/react-color-selector
This is being developed for an organisation. But can it be added as a new component in material-ui?
If not this, the material-ui surely needs a ColorPicker component similar to this.
Suggestions and critiques most welcome.
Here are some other designs: https://dribbble.com/search?q=material+colorpicker
Very cool! Also worth a mention is that you developed it, and it's built on Material-UI. :+1:
As for making it part of Material-UI itself, I think the community may be better served if it remains a standalone project, and we link to it in the 'Related projects' section of the docs, but that's just one opinion. @callemall/material-ui ?
Although helpful, I think since a color picker is neither part of the material design guidelines, nor something that's required by or found in most applications, it shouldn't be a part of material-ui. It seems like more of a component that can be implemented by a third party library.
it shouldn't be a part of material-ui
I agree.
However, this component could be really useful for the Theme
section of the documentation.
We could let user pick a primary and a secondary color. Those colors would be reflected on the all doc site, as switching from the dark / _light_ theme is doing it today.
Nice idea! It would be good exposure @adhbh's component too.
So are you planning to make color picker component?..
@pavel06081991 From what I understand, this component has already been done by @adhbh here: https://github.com/adhbh/react-color-selector.
@adhbh We could add a link to your component under the Related projects
section of the documentation. However, I think that we need a demo page to do so.
Any progress on this ? ;)
@LoicMahieu Project seems dates and there are good alternatives https://github.com/casesandberg/react-color
@LoicMahieu If by "progress" you mean adding a color picker to Material-UI, we pretty much agreed that was better served by standalone components, so this issue should have been closed sooner. (It is now 馃槃 )
@Rosenblad It's an open source component - all it needs is its dependencies bumped and it's good to go. There are, as you say, plenty of alternatives react-color
being a comprehensive if somewhat heavyweight one. It depends on your requirements and priorities.
@mbrookes Sure it is better as standalone component : https://github.com/LoicMahieu/material-ui-color-picker ;)
Most helpful comment
@mbrookes Sure it is better as standalone component : https://github.com/LoicMahieu/material-ui-color-picker ;)