Material-ui: [Snackbar] Make composable

[piotr-dobrogost]

Although it's against material ui guidelines regarding snackbar – Components– Snackbars & toasts – some users find it odd not to have close icon in snackbar and Google itself uses snackbar with close icon in its Inbox web app as shown below:

As currently it's not possible to extend Snackbar with this icon without basically reimplementing whole component I propose to add optional close icon to snackbar.

[piotr-dobrogost]

@nathanmarks
?

[nathanmarks]

@piotr-dobrogost Adding an optional close action is the wrong direction. The component should be composable instead.

[piotr-dobrogost]

Thanks for changing title and reopening.

[Shahrukh-Zindani]

Material design specs clearly say that for two or more actions you should use a dialog box and not a Snackbar so I think making it composable might also not be the right direction. @oliviertassinari
Why don't you want the action button to be defined as a Flat Button inside the API? As action Button is always a clickable text so why not make it easy for the user by creating a Flat Button inside the API letting the user to pass only the text?

[oliviertassinari]

why not make it easy for the user by creating a Flat Button inside the API letting the user to pass only the text?

Because users want to mess around, change properties, add an icon, etc.

[Shahrukh-Zindani]

Right. I get that but how close to material design specs will that user be if he adds icons and messes around as Snack bar is supposed to have a message and an action button only. I guess I can expose the action prop and in the demos use an example with a Button that shows the most common Snackbar example.

[stunaz]

I would say that is up to the users to decide if they want to be close as possible to the material design specs. With the Snack bar being composable, users can easily achieve what is in the Material Design specs, but they can also do more.