Material-ui-pickers: Can't resolve 'react-event-listener'

[jackjwilliams]

Environment

| Tech | Version |
|---------------------|---------|
| material-ui-pickers | 1.0.0-rc.9 |
| material-ui | 1.2 |
| React | 16.3 |
| Browser | Chrome Latest |
| Platform | |

Steps to reproduce

1. npm run build

Expected behavior

The build to pass

Actual behavior

I've gotten all the rest of this issues fixed, except this one.

ERROR in ./node_modules/material-ui-pickers/DatePicker/Calendar.js
    Module not found: Error: Can't resolve 'react-event-listener' in 'C:\Projects\Work\PROJ\src\node_modules\material-ui-pickers\DatePicker'
     @ ./node_modules/material-ui-pickers/DatePicker/Calendar.js 40:26-57

ERROR in ./node_modules/material-ui-pickers/_shared/ModalDialog.js
    Module not found: Error: Can't resolve 'react-event-listener' in 'C:\Projects\Work\PROJ\src\node_modules\material-ui-pickers\_shared'
     @ ./node_modules/material-ui-pickers/_shared/ModalDialog.js 32:26-57

I see the imports in these two files:

https://github.com/dmtrKovalenko/material-ui-pickers/search?q=react-event-listener&unscoped_q=react-event-listener

Yet I see no dependency on it in the package.json, am I missing something?

Live example

[oallouch]

+1

[dmtrKovalenko]

Ha. It was included as dependency in material ui

[cherniavskii]

And it’s still included https://github.com/mui-org/material-ui/blob/2d31ad0eb3b04843fcae01a731601d9fa2b63860/packages/material-ui/package.json#L57

[oallouch]

That's weird. I had to include it myself.
Ok, no big deal.

[jackjwilliams]

Yeah, I had to too, strange

[mnesov]

@dmtrKovalenko Why did you closed the issue, is it fixed?

[mnesov]

Still have Module not found: Can't resolve 'react-event-listener' error, and still have to add react-event-listener dependency to my project.

[dmtrKovalenko]

I found the reason!
We will fix it in the next release, please do npm i react-event-listener for now

[dmtrKovalenko]

Closed because this was fixed in the previous release :)