Material-table: isEditable conditional is broken in version 1.54.1

Created on 12 Nov 2019  路  11Comments  路  Source: mbrn/material-table

Describe the bug
isEditable is not working in version 1.54.1. It works fine in version 1.54.0. If the condition is set to false, you can edit the row anyway.

To Reproduce

editable={{               
    isEditable: rowData => false,
    onRowUpdate: (newData, oldData) =>
        new Promise((resolve, reject) => {
            setTimeout(() => {
                {
                      /* const data = this.state.data;
                      const index = data.indexOf(oldData);
                      data[index] = newData;                
                      this.setState({ data }, () => resolve()); */
                 }
                 resolve();
                 }, 1000);
              }),
         }}

Expected behavior
The edit action button is disabled

wontfix

Most helpful comment

@william13murphy i do not confirm.
Just updated my version to 1.57.2 and its seems to be working

          editable={{
            isEditable: rowData => selectedSubst.includes(rowData.id),
            onRowUpdate: (newData, oldData) => {},
          }}

All 11 comments

(This repo needs some unit tests)

I confirm. not only isEditable, but also isDeletable too

I can confirm it also

this issue is still in version 1.54.2

I can confirm it also, isEditable is not working yet... Please confirm @benrawn commit

Also running into this issue

Also experiencing this. I used patch-package module to apply the change for my project. Thanks @benrawn for the fix.

I am still experiencing this issue in 1.57.2. Can anybody else confirm?

@william13murphy i do not confirm.
Just updated my version to 1.57.2 and its seems to be working

          editable={{
            isEditable: rowData => selectedSubst.includes(rowData.id),
            onRowUpdate: (newData, oldData) => {},
          }}

@LuisPinaSoares Thank you for your response. isEditable is working as intended!!

Thank you package managers/contributors for a wonderful library.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. You can reopen it if it required.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

ModPhoenix picture ModPhoenix  路  3Comments

roseak picture roseak  路  3Comments

lazeebee picture lazeebee  路  3Comments

kfirshahar picture kfirshahar  路  3Comments

timrchavez picture timrchavez  路  3Comments