Material-dialogs: Dialogs are too wide/tall

[tihomirleka]

For some reason dialogs are too wide when compared to standard android dialogs. First I noticed it with dialog that had a custom view set, and thought my view is problem, but then I tried standard list dialog and progress dialog and both dialog have the exact same problem. I attached some screenshots so you can better understand what am I talking about and below is code for showing the dialogs.

I'm testing on Nexus 5 with Android 6.0.1 and the latest version of the library.

new MaterialDialog.Builder(context).theme(Theme.LIGHT)
            .titleColorRes(R.color.gray_dark)
            .negativeColorRes(R.color.orange)
            .positiveColorRes(R.color.orange)
            .title(R.string.dialog_title_task_due_date_reminder_set_custom)
            .customView(R.layout.dialog_task_due_date_reminder, false)
            .negativeText(R.string.action_close)
            .positiveText(R.string.ok)

new MaterialDialog.Builder(context).theme(Theme.LIGHT)
            .titleColorRes(R.color.gray_dark)
            .negativeColorRes(R.color.orange)
            .positiveColorRes(R.color.orange)
            .adapter(adapter, layoutManager)
            .negativeText(context.getString(R.string.action_close))
            .cancelable(true)
            .cancelListener(new DialogInterface.OnCancelListener() {
                @Override public void onCancel(DialogInterface dialog) {
                    dialog.dismiss();
                }
            });

new MaterialDialog.Builder(this).theme(Theme.LIGHT)
                    .titleColorRes(R.color.gray_dark)
                    .negativeColorRes(R.color.orange)
                    .positiveColorRes(R.color.orange)
                    .progress(true, 0)
                    .show();

Anu idea why this is happening?

[cioccarellia]

Having the same problem. Dialogs uses the 100% of the screen

new FolderChooserDialog.Builder(MainActivity.this)
            .chooseButton(R.string.md_choose_label)  // changes label of the choose button
            .initialPath("/")  // changes initial path, defaults to external storage directory
            .tag("0")
            .show();

[afollestad]

That's super weird, something must have changed with the newer version of AppCompat.

[tihomirleka]

So, I tried out some of the old versions of material-dialogs library and it seems the bug is introduced in version 0.9.2.0. I used latest version of support library (25.1.0) and decreased md lib version and I got normal width when I got to version 0.9.1.0. So I guess workaround for now is to stick with version 0.9.1.0 until there is a fix.

[afollestad]

@tihomirleka well, the only change that could have affected this was the AppCompat 25.1.0 update. I will probably need to put some manually height/width limiting logic in there now.

[afollestad]

Fixed for the next release

[afollestad]

https://github.com/afollestad/material-dialogs/releases/tag/0.9.2.2

[rfazi]

After this release now the dialog occupy all width of the device.
I have LG G3.

[afollestad]

@rfazi use the latest version that I just commented above you. :P

[rfazi]

I'm use the version you commited above.
Turn back to the 0.9.2.1 resolve the problem.

Edit: Turn back to the 0.9.1.0 resolve the problem.

[basefas]

I have the same problem on the 0.9.2.2 version.I'm testing on Nexus 5 with Android 6.0.1 and buildToolsVersion is 25.0.2, support library is 25.1.0.

[ritdaw]

Same issue on 0.9.2.2. Android 6.0.1.

[tihomirleka]

I tried it out with latest release of the library and have the same issue. The dialogs now occupies full width of the screen. As I said, the last version that doesn't present the width bug is 0.9.1.0.

[afollestad]

Odd.

It works on my Pixel XL, Nexus 6P, Nexus 5X, and Nexus 9. Plus a Pixel C emulator.

@tihomirleka @ritdaw @basefas

[rfazi]

@afollestad Sorry I'm confused, the problem persist in 0.9.2.1.
Revert back to 0.9.1.0 resolve the problem.

[afollestad]

Well it doesn't seem to be an issue on my end.

[goldmont]

Also on my Galaxy S6 Flat the dialog occupies all the width.

Android 6.0.1 and version 9.0.2.2

[franciscofranco]

I'm also affected with 0.9.2.2, all latest versions of appcompat etc on my Nexus 5. Can debug whatever if needed.

[afollestad]

Hmm... @franciscofranco @peppe130 @rfazi @tihomirleka @ritdaw @basefas

---

Does it still happen on your devices from the sample app? https://github.com/afollestad/material-dialogs/raw/master/sample/sample.apk

[basefas]

I clone the project and install it on my Nexus5 ,has the same problem，the same as your sample.apk

[ritdaw]

This is from the 0.9.2.2 release on Google Play. Android 6.0.1 (Moto Z Play).

[PavelSynek]

Nexus 5, Android 6.0.1

[rfazi]

LG G3 Android 6

[tihomirleka]

Different devices, resolutions and Android versions, all taken on actual devices, not emulators.

Hope this helps.

[rfazi]

@afollestad Maybe the problem is the new dimension?

<dimen name="md_dialog_max_width">

[riadhnet]

same problem here with samsung galaxy s5

[afollestad]

@rfazi probably, but it shouldn't be an issue since it uses Material specs for that. Not sure why it would work fine on my devices and not on yours. 😭

[afollestad]

That is helpful @tihomirleka, thanks

[tihomirleka]

No problem. Let me know if you want me to re-test on all devices after the fix.

[afollestad]

@tihomirleka can you check the updated sample? https://github.com/afollestad/material-dialogs/raw/master/sample/sample.apk

[tihomirleka]

Looks like its fixed.

[afollestad]

Thanks!

https://github.com/afollestad/material-dialogs/releases/tag/0.9.2.3