Material-design-lite: Implement Subheader v2 Component
Spec reference: https://material.google.com/components/subheaders.html
traviskaufman
All 2 comments
I think with the subheader space it would be best to add subheadings into the components that they are defined for. This has been a quirky thing about the specification for a while with me. I don't understand why this is its own component defining a single piece of 3-4 other specs, when it should just be a section within those specifications. That way the class naming is more streamlined.
.mdl-menu__subheading vs .mdl-subheading--menu, I think the former version is much better for developers given the scoping of the BEM syntax we use.
Garbee
on 29 Jun 2016
👍3
sfdexter
on 16 Dec 2016
Was this page helpful?
0 / 5 - 0 ratings
Related issues
tleunen
路
5Comments
dryror
路
5Comments
facekapow
路
5Comments
traviskaufman
路
5Comments
nisrulz
路
5Comments
Most helpful comment
I think with the subheader space it would be best to add subheadings into the components that they are defined for. This has been a quirky thing about the specification for a while with me. I don't understand why this is its own component defining a single piece of 3-4 other specs, when it should just be a section within those specifications. That way the class naming is more streamlined.
.mdl-menu__subheadingvs.mdl-subheading--menu, I think the former version is much better for developers given the scoping of the BEM syntax we use.