First MDC-Web is looking great! Great progress!
On the individual component demo pages, e.g. slider, viewing page source shows uglified code. Ideally, one should be encouraged to view the page source for further instruction on how to stand these components up.
Please do not uglify or obfuscate the demo code. Pretty print the HTML and use ES5 scripting. The KISS principle.
Thank you!
Hi @rhroyston, thanks for pointing this out!
We're planning on adding code snippets next to every demo, first in vanilla JS for the MDC Web library, and then also in React once the MDC React component library is ready. Ideally, these snippets will contain the code that actually generates the components on the page.
Any web developer knows how to view source code. Just don't uglify the
source code on the demo pages and keep any required CSS and JS in the demo
document and keep it simple, no js closures or ES6 or clever coding. Just
basic plain simple examples. ...Just trying to help.
On Mon, May 14, 2018 at 7:06 PM, Bonnie Zhou notifications@github.com
wrote:
Hi @rhroyston https://github.com/rhroyston, thanks for pointing this
out!
We're planning on adding code snippets next to every demo, first in
vanilla JS for the MDC Web library, and then also in React once the MDC
React
https://github.com/material-components/material-components-web-react
component library is ready. Ideally, these snippets will contain the code
that actually generates the components on the page.—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/material-components/material-components-web/issues/2735#issuecomment-389000865,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMKS-373CiukxA-bnwN-geGumhTEfp0hks5tyhwGgaJpZM4T8mEe
.
--
Most helpful comment
Any web developer knows how to view source code. Just don't uglify the
source code on the demo pages and keep any required CSS and JS in the demo
document and keep it simple, no js closures or ES6 or clever coding. Just
basic plain simple examples. ...Just trying to help.
On Mon, May 14, 2018 at 7:06 PM, Bonnie Zhou notifications@github.com
wrote:
--
(318) 560-0145
https://rack.pub