Material-components-android: [MaterialButton] Add support for TOP & BOTTOM icon gravity
Is your feature request related to a problem? Please describe.
Up until release 1.1.0-alpha06 back in May 2019, the only way to change the icon position was done using TextViewCompat.setCompoundDrawablesRelative.
After introducing new method setIconGravity in release 1.1.0-alpha06 it was finally possible to properly set the icon position, although only on the right or left, and close to the text or not.
This now excludes the possibility to place the icon either on top or bottom relative to the text.
Describe the solution you'd like
Please kindly add TOP & BOTTOM gravity as part of @IconGravity.
Describe alternatives you've considered
As said at the beginning, before release 1.1.0-alpha06, the only way to change the icon position was using TextViewCompat.setCompoundDrawablesRelative.
This no longer works, as it triggers a requestLayout which, at some point, will trigger updateIconPosition and then updateIcon where only START/TEXT & END/TEXT are supported.
ricard-v
All 19 comments
It is not a bad idea but currently the material guideline specs are against this scenario.
At some point here: https://material.io/components/buttons/#contained-button
You will find this image:
Which exactly cover this case
matpag
on 11 Oct 2019
Actually, in Gmail, there are buttons which have the icon on the left, but when insufficient width is there, they push the icon on the top. Seems pretty useful.
hrach
on 11 Oct 2019
Actually, in Gmail, there are buttons which have the icon on the left, but when insufficient width is there, they push the icon on the top. Seems pretty useful.
Agree 100%, I think it is a useful feature
matpag
on 11 Oct 2019
Actually, in Gmail, there are buttons which have the icon on the left, but when insufficient width is there, they push the icon on the top. Seems pretty useful.
Agree 100%, I think it is a useful feature
Yes this is exactly the point. The project's lead designer just told me "top icon is required to provide more flexibility with the text".
ricard-v
on 11 Oct 2019
We got approval from design to support adding gravity Top. However we'll leave the guideline in material.io since it should be only for edge cases
ymarian
on 16 Oct 2019
That's great news ! Thanks. When could I expect the support ?
ricard-v
on 23 Oct 2019
Any news on this feature?
alex-dokienko
on 13 Dec 2019
Bump
antonkovalyov351
on 15 Mar 2020
Can you make it available on the next alpha version?
rewgoes
on 17 Mar 2020
I've sent a PR adding top gravity only, let's wait if it is approved!
rewgoes
on 22 Mar 2020
any update of this gravity top? 鈽癸笍
kadaluarsa
on 4 May 2020
@ymarian do you know if the designers changed their mind about aligning icon on top? My PR was merged and then rollbacked.
rewgoes
on 31 May 2020
It was rolled back due to internal breakages, we are still trying to fix them so we can roll the change forward.
wcshi
on 1 Jun 2020
Let me know if I can help with any changes.
rewgoes
on 1 Jun 2020
@ymarian can we close this issue?
rewgoes
on 9 Jun 2020
Finally landed in b39845a452f547d5844996074ac9aabe911d637f. Thanks @rewgoes!
hunterstich
on 1 Jul 2020
Is it available for use now in any of the versions?
karanjhinga
on 10 Jul 2020
@karanjhinga Not yet, no. It should be in the next 1.3.0-alpha02 release
hunterstich
on 10 Jul 2020
@karanjhinga you can use the snapshot release
gabrielemariotti
on 10 Jul 2020
Related issues
TdevM
路
3Comments
ataulm
路
3Comments
magnusfernandes
路
3Comments
gabrielemariotti
路
3Comments
ahmaducg
路
3Comments
Most helpful comment
I've sent a PR adding top gravity only, let's wait if it is approved!