Mastodon: PgHero Connections graphs broken on master

Created on 12 Oct 2018 · 6Comments · Source: tootsuite/mastodon

When testing from master today (at 9d4541c) it seems the graphs on the PgHero / Connections page (ex: https://mastodon.social/pghero/connections) are broken:

This only started happening recently, somewhere between 2.5.0 and now. I confirmed the same regression on a second instance. Graphs load on 2.5.0, but don't when running from master.

It doesn't seem very impactful since only admins can access pghero.

[x] I searched or browsed the repo’s other issues to ensure this is not a duplicate.
[ ] This bug happens on a tagged release and not on master (If you're a user, don't worry about this).

bug

Source

33b5e5

Most helpful comment

I think that ankane/pghero#239 might do it.

Gargron on 12 Oct 2018

👍2

All 6 comments

do you happends to have a content-security-policy set by your nginx/apache vhost ?

it seems it may block the loading of the graphs if not authorizing the right thing (browser console should spew errors in that case)

rhaamo on 12 Oct 2018

The new CSP rules added in #8957 block inline scripts. The charts are created using inline scripts. I think that either PgHero needs to add controller-specific CSP whitelisting upstream, or we need to monkeypatch it.

Gargron on 12 Oct 2018

I think that ankane/pghero#239 might do it.

Gargron on 12 Oct 2018

👍2

Just noting: Still broken.

grinapo on 24 Jul 2019

👍1

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.