People have noticed that shortcodes in display names are no longer rendering as emoji on master; see https://dev.glitch.social/users/MightyPork/updates/9587 . I've noticed #4189 or #4202 as recent emoji-related pulls; is this related to those or is something else interfering?
master (If you're a user, don't worry about this).Folks must re-save their profile. Shortcodes will be converted to unicode then. The JS no longer handles shortcodes.
We could probably have a db:migrate thing that does that automatically?
You may know that updates on the display_name column take relatively long because of a search index. It's not a viable migrate. It's also a task in ruby code, meaning each row update would have to go through ruby.
It's probably reasonable to fix this for local users in a sidekiq task. I think figuring out how to run cleanup/integrity-type background tasks as a migration-like action is useful and comes up often enough that we should put work into fixing this.
I think this is mostly a non-issue because over time more and more people just update their profile, especially if they see the shortcode instead of the emoji.
Most helpful comment
It's probably reasonable to fix this for local users in a sidekiq task. I think figuring out how to run cleanup/integrity-type background tasks as a migration-like action is useful and comes up often enough that we should put work into fixing this.