Mastodon: Commit d755ce96da00cee1c8e51204cf5ede79764f4fb9 break autorefresh

Created on 6 Apr 2017 · 17Comments · Source: tootsuite/mastodon

Commit d755ce96da00cee1c8e51204cf5ede79764f4fb9 break column's autorefresh. I have a lot of attempts task in Sidekiq (cf screenshot). Downgrade to 29ffe1cad3f473c7b6c0b651d065f8ed9373d37e fix the problem.

20170406004426798

Source

luclu7

👍6

Most helpful comment

I can confirm. I had to downgrade.

Wonderfall on 6 Apr 2017

👍2

All 17 comments

I can confirm. I had to downgrade.

Wonderfall on 6 Apr 2017

👍2

Is the latest build on https://hub.docker.com/r/gargron/mastodon/tags/ impacted ?

valentin2105 on 6 Apr 2017

Yes, it's impacted.

luclu7 on 6 Apr 2017

👍1

Can also confirm on my server, all is working well after a downgrade to 29ffe1cad3f473c7b6c0b651d065f8ed9373d37e.

dekonnection on 6 Apr 2017

Got the same issue on my instance. Everything working well after downgrade to commit 29ffe1cad3f473c7b6c0b651d065f8ed9373d37e

alex73630 on 6 Apr 2017

I know where this happens, I'll get a PR made quickly.

krainboltgreene on 6 Apr 2017

You need to be on at least d13d169922c7efeb6e6c20ef6a271eeda552275f, I am not sure why you had d755ce9 since it wasn't pushed into master by itself...

Gargron on 6 Apr 2017

Do we need some kind of tests-passed branch like @Discourse does?

When a commit lands on master, it's put through an internal CI test and only when it passes is it pushed to tests-passed, which is where everyone pulls updates from.

riking on 6 Apr 2017

@riking That is a fantastic idea! Do you know how to setup that?

Gargron on 6 Apr 2017

I think it's a completion hook on a Travis job triggered on GitHub pushes. Of course, we need to have tests that will catch this kind of thing breaking.

riking on 6 Apr 2017

This is fixed ? We can upgrade ? :°

Miaourt on 6 Apr 2017

I pulled from the master branch ( from b142a2e to 51d7caa ) and restarted Mastodon, I don't have this issue on my instance.

mkody on 6 Apr 2017

We need confirmation before upgrade our instance please ! :) thanks you

valentin2105 on 6 Apr 2017

I upgraded a few hours ago and it has been fixed. :)

angristan on 6 Apr 2017

The better solution is to just adopt github squash commit merge.

On Apr 6, 2017 5:57 AM, "Angristan" notifications@github.com wrote:

I upgraded a few hours ago and it has been fixed. :)

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/tootsuite/mastodon/issues/1008#issuecomment-292166013,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAUb2aDlmqXVfUHw_noHQgfjG0xRfR3oks5rtOEwgaJpZM4M06iG
.