Marlin: [BUG] SKR Pro - TMC2209 UART - only X driver gets serial address

[PGrave]

SKR Pro - TMC2209 UART - only X driver gets serial address

Steps to Reproduce

GIT_REPORT.zip

1. [Compile latest Marlin 2.0]
2. [Flash firmware]
3. [TMC CONNECTION ERROR on display]
4. [M122 on Octoprint shows X driver with address and communication enabled, no addresses and no communication with Y, Z, E, E1]

Expected behavior: [All drivers with UART communication ]

Actual behavior: [Only X axis driver communicates]

Additional Information

Previous compiled and working firmware using [email protected]; BTT Serial TMC; might be related to (#15655)

[sjasonsmith]

How are your jumpers configured beneath the drivers?

[sjasonsmith]

If you take a picture at an angle I think you can see all the pins near and under the drivers without removing them. I would just like to confirm that all the jumpers look correct to match your config. I'm going to try talking to multiple 2209s on my board, I only used a 2209 on X when I initially tested.

[sjasonsmith]

OK, it is working for me. I only have four 2209 drivers, so I only have X through E.
I just rebased this config, so it is my SKR Pro configs on top of 27cb4db80eae73eb842f1a944260517bb8783eb3 .

                X       Y       Z       E
Address         0       0       0       0
Enabled         false   false   false   false
Set current     800     800     800     800
RMS current     795     795     795     795
MAX current     1121    1121    1121    1121
Run current     25/31   25/31   25/31   25/31
Hold current    12/31   12/31   12/31   12/31
CS actual       12/31   12/31   12/31   12/31
PWM scale       14      14      14      14
vsense          1=.18   1=.18   1=.18   1=.18
stealthChop     true    true    true    true
msteps          16      16      16      16
tstep           max     max     max     max
pwm
threshold
[mm/s]
OT prewarn      false   false   false   false
off time        4       4       4       4
blank time      24      24      24      24
hysteresis
-end            2       2       2       2
-start          1       1       1       1
Stallguard thrs 0       0       0       0
DRVSTATUS       X       Y       Z       E
stst            *       *       *       *
olb
ola
s2gb
s2ga
otpw
ot
157C
150C
143C
120C
s2vsa
s2vsb
Driver registers:
                X       0xC0:0C:00:00
                Y       0xC0:0C:00:00
                Z       0xC0:0C:00:00
                E       0xC0:0C:00:00


Testing X connection... OK
Testing Y connection... OK
Testing Z connection... OK
Testing E connection... OK
ok

[PGrave]

Hello @sjasonsmith and thank you for your reply. First of all, let me tell you that this configuration has been printing ok with Marlin 2.0, compiled on 26-10-2019. Just downloaded current version, changed configuration, configuration_adv and pins files to match my hardware. Compared versions old with new, just updated my specifics on new files. I updated and upgraded platform (PlatformIo on VSCode) and libraries. So, no hardware changes or modifications since last compile, a few days ago, just software.

[sjasonsmith]

Do you have your old configs? Can you verify the slave addresses you used in Configuration_adv.h when it was working? My initial guess would be that jumpers are configuring non-zero slave addresses for the drivers, but the current config is all zero (as is mine).

[PGrave]

Jumpers are all in the same position, UART, and slave addresses all zero on configuration_adv. Haven't changed that part of the configuration. While using BTT serial implementation (previous compile), drivers get addresses. I'll try to send a screen from M122 report, I've downgraded to previous firmware and all is working.

[sjasonsmith]

Could you take a picture of the jumpers? I understand that you haven't changed anything, but I can't figure out why it works fine on my board and not yours, if we are doing the same thing.

[PGrave]

I've also sent a zip file with my configs and platformIo compile log.

[PGrave]

Picture of jumpers above,
and this is a current M122 result:

Send: M122
Recv:       X   Y   Z   E   E1
Recv: Address       0   0   0   0   0
Recv: Enabled       false   false   false   false   false
Recv: Set current   550 550 550 450 450
Recv: RMS current   520 520 520 428 428
Recv: MAX current   733 733 733 603 603
Recv: Run current   16/31   16/31   16/31   13/31   13/31
Recv: Hold current  8/31    8/31    8/31    6/31    6/31
Recv: CS actual 8/31    8/31    8/31    6/31    6/31
Recv: PWM scale 10  10  10  7   7
Recv: vsense        1=.18   1=.18   1=.18   1=.18   1=.18
Recv: stealthChop   true    true    true    true    true
Recv: msteps        16  16  16  16  16
Recv: tstep     max max max max max
Recv: pwm
Recv: threshold 98  98  658 64  64
Recv: [mm/s]        100 100 3   30  30
Recv: OT prewarn    false   false   false   false   false
Recv: OT prewarn has
Recv: been triggered    false   false   false   false   false
Recv: off time  4   4   4   4   4
Recv: blank time    24  24  24  24  24
Recv: hysteresis
Recv: -end      2   2   2   2   2
Recv: -start        1   1   1   1   1
Recv: Stallguard thrs   0   0   0   0   0
Recv: DRVSTATUS X   Y   Z   E   E1
Recv: stst      *   *   *   *   *
Recv: olb
Recv: ola
Recv: s2gb
Recv: s2ga
Recv: otpw
Recv: ot
Recv: 157C
Recv: 150C
Recv: 143C
Recv: 120C
Recv: s2vsa
Recv: s2vsb
Recv: Driver registers:
Recv:       X   0xC0:08:00:00
Recv:       Y   0xC0:08:00:00
Recv:       Z   0xC0:08:00:00
Recv:       E   0xC0:06:00:00
Recv:       E1  0xC0:06:00:00
Recv: 
Recv: 
Recv: Testing X connection... OK
Recv: Testing Y connection... OK
Recv: Testing Z connection... OK
Recv: Testing E connection... OK
Recv: Testing E1 connection... OK
Recv: ok 

[sjasonsmith]

What is wrong with that M122 result? This is with your old firmware or the new firmware?

[PGrave]

This is my old firmware, to which I've returned. So, to be clear: from this working setup to the not working one, just Marlin version, new STM32 5.7.0, default Marlin TMC library and my changes/adapts on the config files.

[sjasonsmith]

Can you post your configs for the old/working firmware, like you did for the new firmware?

[PGrave]

On the new configuration, which is not loaded on the machine now, only X driver gets an address. I'll reflash new firmware (it has to be later, sorry) and paste here the result of M122.
Please be aware that the files in the zip on the first post are the NEW configs. Maybe those can be useful, might be a stupid mistake from me, too many awaken hours :) Thanks in advance for any possible help!

[thinkyhead]

As always, be sure to use M502, M500 after flashing to ensure no stale data comes into play.

[PGrave]

Thank you @thinkyhead for your help. I've init memory by the display command, which was acknowledged with a confirmation response. Then
a save configuration command. But I can and will issue those by serial console, after reflashing with new firmware, just to ensure.

[LinoBarreca]

It looks like you are using tmcstepper 0.6.0

[LinoBarreca]

@sjasonsmith do you?

[sjasonsmith]

No. I just checked, but I don't even see 0.6 in the TMCStepper repo? They released in PIO but not on github?

[sjasonsmith]

I was using 0.5.2.

[LinoBarreca]

@PGrave did you download them manually from somewhere or was it automatic?

[sjasonsmith]

Hmm...looks like TMCStepper is now changing pin direction itself, instead of letting SoftwareSerial do it. Something is probably wrong with that. At least with STM32 SoftwareSerial already does half-duplex itself.

I can't look at it tonight. The solution for now is probably to change the platformio.ini file to require exactly TMCStepper 0.5.2.

[LinoBarreca]

@sjasonsmith Does spi use softserial?
Why should it? I rather guess that tmcstepper uses 5.7.0 spi library

[sjasonsmith]

SPI is separate. SoftwareSerial is only used for 2208/2209 drivers, which use a UART. I don't know what TMCStepper uses for SPI, I don't have any SPI drivers.

[LinoBarreca]

Oh. I'm sorry. I read it wrong. He's on uart. Sorry. I was boarding the plane. Be back in 3h.

[thisiskeithb]

Marlin likely needs to be patched: https://github.com/teemuatlut/TMCStepper/issues/93

[LinoBarreca]

Likely tmcstepper needs to be patched...since, if it's as @sjasonsmith said, the next stm framework (5.8.0) will contain the same softserial which is in marlin now.

[LinoBarreca]

Maybe @teemuatlut should be involved here as well.

[PGrave]

It should work with TMC0.5.2. To force it, use the change made on platformIo.ini and you should use platformIo "Clean" option, to clean the .pio folder and force the download of new libraries. I think like that it will load the 0.5.2 version.
I haven't tested it yet, but should go fine like that.

[PGrave]

Tested with TMC0.5.2, M122 result:
Send: M122
Recv: X Y Z E E1
Recv: Address 0 0 0 0 0
Recv: Enabled false false false false false
Recv: Set current 550 550 550 550 550
Recv: RMS current 520 520 520 520 520
Recv: MAX current 733 733 733 733 733
Recv: Run current 16/31 16/31 16/31 16/31 16/31
Recv: Hold current 8/31 8/31 8/31 8/31 8/31
Recv: CS actual 8/31 8/31 8/31 8/31 8/31
Recv: PWM scale 10 10 10 10 10
Recv: vsense 1=.18 1=.18 1=.18 1=.18 1=.18
Recv: stealthChop true true true true true
Recv: msteps 16 16 16 16 16
Recv: tstep max max max max max
Recv: pwm
Recv: threshold 98 98 658 64 64
Recv: [mm/s] 100 100 3 30 30
Recv: OT prewarn false false false false false
Recv: off time 4 4 4 4 4
Recv: blank time 24 24 24 24 24
Recv: hysteresis
Recv: -end 2 2 2 2 2
Recv: -start 1 1 1 1 1
Recv: Stallguard thrs 0 0 0 0 0
Recv: DRVSTATUS X Y Z E E1
Recv: stst * * * * *
Recv: olb
Recv: ola
Recv: s2gb
Recv: s2ga
Recv: otpw
Recv: ot
Recv: 157C
Recv: 150C
Recv: 143C
Recv: 120C
Recv: s2vsa
Recv: s2vsb
Recv: Driver registers:
Recv: X 0xC0:08:00:00
Recv: Y 0xC0:08:00:00
Recv: Z 0xC0:08:00:00
Recv: E 0xC0:08:00:00
Recv: E1 0xC0:08:00:00
Recv:
Recv:
Recv: Testing X connection... OK
Recv: Testing Y connection... OK
Recv: Testing Z connection... OK
Recv: Testing E connection... OK
Recv: Testing E1 connection... OK
Recv: ok

[PGrave]

Tested with TMC0.6.1, M122 result:
Send: M122
Recv: X Y Z E E1
Recv: Address 0 0 0 0 0
Recv: Enabled false false false false false
Recv: Set current 550 550 550 550 550
Recv: RMS current 520 520 520 520 520
Recv: MAX current 733 733 733 733 733
Recv: Run current 16/31 16/31 16/31 16/31 16/31
Recv: Hold current 8/31 8/31 8/31 8/31 8/31
Recv: CS actual 8/31 8/31 8/31 8/31 8/31
Recv: PWM scale 10 10 10 10 10
Recv: vsense 1=.18 1=.18 1=.18 1=.18 1=.18
Recv: stealthChop true true true true true
Recv: msteps 16 16 16 16 16
Recv: tstep max max max max max
Recv: pwm
Recv: threshold 98 98 658 64 64
Recv: [mm/s] 100 100 3 30 30
Recv: OT prewarn false false false false false
Recv: off time 4 4 4 4 4
Recv: blank time 24 24 24 24 24
Recv: hysteresis
Recv: -end 2 2 2 2 2
Recv: -start 1 1 1 1 1
Recv: Stallguard thrs 0 0 0 0 0
Recv: DRVSTATUS X Y Z E E1
Recv: stst * * * * *
Recv: olb
Recv: ola
Recv: s2gb
Recv: s2ga
Recv: otpw
Recv: ot
Recv: 157C
Recv: 150C
Recv: 143C
Recv: 120C
Recv: s2vsa
Recv: s2vsb
Recv: Driver registers:
Recv: X 0xC0:08:00:00
Recv: Y 0xC0:08:00:00
Recv: Z 0xC0:08:00:00
Recv: E 0xC0:08:00:00
Recv: E1 0xC0:08:00:00
Recv:
Recv:
Recv: Testing X connection... OK
Recv: Testing Y connection... OK
Recv: Testing Z connection... OK
Recv: Testing E connection... OK
Recv: Testing E1 connection... OK
Recv: ok

[PGrave]

From my side, this is a closed issue. Thanks to all that helped! Go Marlin Team! :)

[github-actions[bot]]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.