Marlin: 1.1.8-bugfix: "Fade height" on LCD wrong

Created on 16 May 2018 · 11Comments · Source: MarlinFirmware/Marlin

Hi!
I have a problem, and dont know if this is a bug or ok: Fade height shown by M503 is 2mm, on LCD showing 0mm. If I change this on the LCD to 1mm, M503 shows 1mm.
When I save this, and restart printer, M503 shows 1mm, but again 0mm on the LCD.

Best regards!

Potential ? LCD & Controllers

Source

insanity67

All 11 comments

Sounds like a potential bug. We'll look into it!

thinkyhead on 16 May 2018

👍1

on LCD showing 0mm

I assume you mean, when you go to the "Tune" menu or the "Bed Leveling" menu and want to edit the value, it shows 0 as the current edit value, yes?

thinkyhead on 16 May 2018

Yes, the current value shown is always 0.00 after restart/reset of the printer. Looks like the value is read from EEPROM at boot (because showing in M503) but somehow the LCD uses another variable to show that is not populated?!

insanity67 on 16 May 2018

And you are using the latest bugfix-1.1.x branch? So far as I can tell, in the current code that temporary variable _is being set_ prior to showing the edit item. However, if it's set with M420 Znnn, M501, or M502 then you have to exit and re-enter the menu for it to update on-screen.

thinkyhead on 16 May 2018

Yes the latest branch, pulled yesterday.
OK thanks, I have to test if that happened with M420 Z.
But right after restart/reset it shows 0, there was no M420 at this state?

But, would it not be better to also show the value entered with M420 Z on LCD?

insanity67 on 16 May 2018

Finally had some time to test:
When I power on my printer, in the menu under "tune" the "Fade Height" is 0.00.
As soon as I start a print (even while preheating, no M420 in the GCode) the "Fade Height" is showing the correct value from EEPROM.

Dont know if this is a bug, or a wanted behaviour? I would find it better if the value was there after I start the printer.

insanity67 on 17 May 2018

Ok, so it's good in the Tune menu but incorrect in the Prepare menu.

thinkyhead on 20 May 2018

Yes, Prepare Menu shows 0.0 right after printer power up. As soon as I start the print Prepare changes to Tune, and there is my Value from EEPROM.

insanity67 on 20 May 2018

Ok, I've patched the two bugfix branches to fix the issue. Should work better now.

thinkyhead on 20 May 2018

Compiled, tested -> works! Thanks for your great support!

insanity67 on 20 May 2018

🎉1

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.